Skip to content

fix: rename to Amazon S3 Encryption Client #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

fix: rename to Amazon S3 Encryption Client #89

merged 2 commits into from
Feb 24, 2023

Conversation

kessplas
Copy link
Contributor

@kessplas kessplas commented Feb 22, 2023

Issue #, if available:

Description of changes:

Since S3 is always referred to as Amazon S3, its encryption client should be called the Amazon S3 Encryption Client. This PR updates various names to reflect this in code/config.

I decided against renaming the CodeBuild project for now, as it is not public facing. We may want to change this and rebuild the CFN stacks before public launch.

Also, this repo needs to be renamed before we can update the pom.xml references to it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kessplas kessplas marked this pull request as ready for review February 23, 2023 18:47
Copy link

@aliepaoli aliepaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@imabhichow imabhichow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kessplas kessplas merged commit 4950731 into main Feb 24, 2023
@kessplas kessplas deleted the amazon-s3 branch February 24, 2023 23:25
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Mar 1, 2023
## [2.2.0](v2.1.1...v2.2.0) (2023-03-01)

### Features

* Add S3CrtAsyncClient as MultipartPutobject ([#90](#90)) ([24be141](24be141))
* extend delegating client to enable non-encrypted API operations in default and async encrypion clients ([#94](#94)) ([ba78c2c](ba78c2c))

### Maintenance

* bump AWS SDK v2 deps and make S3 non-optional ([#93](#93)) ([9d0c495](9d0c495))
* change algorithm suite IDs to match the specification ([#86](#86)) ([322e88c](322e88c))
* cleanup some test code ([#92](#92)) ([ba3be52](ba3be52))

### Fixes

* Revert "AWS S3 Encryption Client 1.0.1 Release -- $(date +%Y-%m-%d)" ([0d750cb](0d750cb))
* Revert "AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)" ([80bc1fa](80bc1fa))
* convert to a blocking input stream instead of going through a by… ([#96](#96)) ([eea77c1](eea77c1))
* pass exception from doFinal to wrapped subscriber to avoid hanging ([#95](#95)) ([7c64a9f](7c64a9f))
* Remove default wrapped client ([#81](#81)) ([287a63e](287a63e))
* rename to Amazon S3 Encryption Client ([#89](#89)) ([4950731](4950731))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants