Add comment on not making a defensive copy of plaintext/ciphertext

Author: WesleyRosenblum

src/main/java/com/amazonaws/encryptionsdk/DecryptRequest.java

@@ -46,7 +46,7 @@ public static class Builder extends AwsCryptoRequest.Builder<Builder> {
         private byte[] ciphertext;
 
         /**
-         * Sets the {@link ParsedCiphertext}. Either {@link ParsedCiphertext} or a
+         * Sets the {@link ParsedCiphertext} to decrypt. Either {@link ParsedCiphertext} or a
          * {@code byte[]} ciphertext is required.
          *
          * @param parsedCiphertext The {@link ParsedCiphertext}
@@ -59,8 +59,10 @@ public Builder parsedCiphertext(ParsedCiphertext parsedCiphertext) {
         }
 
         /**
-         * Sets the ciphertext. Either {@link ParsedCiphertext} or a
-         * {@code byte[]} ciphertext is required.
+         * Sets the ciphertext byte array to decrypt. Either {@link ParsedCiphertext} or a
+         * {@code byte[]} ciphertext is required. Note that this does not make a defensive
+         * copy of the ciphertext and so any modifications made to the backing array will be
+         * reflected in this Builder.
          *
          * @param ciphertext The ciphertext
          * @return The Builder, for method chaining

src/main/java/com/amazonaws/encryptionsdk/EncryptRequest.java

@@ -53,8 +53,8 @@ public static class Builder extends AwsCryptoRequest.Builder<Builder> {
         private Map<String, String> encryptionContext = Collections.emptyMap();
 
         /**
-         * Sets the {@link Keyring}. Either a {@link CryptoMaterialsManager} or a
-         * {@link Keyring} is required.
+         * Sets the plaintext byte array to encrypt. Note that this does not make a defensive copy of the
+         * plaintext and so any modifications made to the backing array will be reflected in this Builder.
          *
          * @param plaintext The {@link Keyring}
          * @return The Builder, for method chaining