pylint error fix

Author: RitvikKapila

examples/src/deprecated/pylintrc

@@ -0,0 +1,44 @@
+[MESSAGE CONTROL]
+# Disabling messages that either we don't care about we intentionally break.
+disable =
+    invalid-name,  # we prefer long, descriptive, names for examples
+    bad-continuation,  # we let black handle this
+    ungrouped-imports,  # we let isort handle this
+    no-member,  # breaks with attrs
+    no-self-use,  # interesting to keep in mind for later refactoring, but not blocking
+    useless-object-inheritance,  # we need to support Python 2, so no, not useless
+    duplicate-code,  # some examples may be similar
+    too-few-public-methods,  # does not allow value stores
+    too-many-locals,  # examples may sometimes have more locals defined for clarity than would be appropriate in code
+    no-else-return,  # we omit this on purpose for brevity where it would add no value
+    attribute-defined-outside-init,  # breaks with attrs_post_init
+    abstract-method,  # throws false positives on io.BaseIO grandchildren
+    redefined-outer-name,  # we do this on purpose in multiple places
+    consider-using-f-string # disable until 2022-05-05; 6 months after 3.5 deprecation
+
+[BASIC]
+# Allow function names up to 50 characters
+function-rgx = [a-z_][a-z0-9_]{2,50}$
+# Allow method names up to 50 characters
+method-rgx = [a-z_][a-z0-9_]{2,50}$
+# Allow class attribute names up to 50 characters
+# Whitelist class attribute names: iv
+class-attribute-rgx = (([A-Za-z_][A-Za-z0-9_]{2,50}|(__.*__))$)|(^iv$)
+# Whitelist attribute names: iv
+attr-rgx = ([a-z_][a-z0-9_]{2,30}$)|(^iv$)
+# Whitelist argument names: iv, b
+argument-rgx = ([a-z_][a-z0-9_]{2,30}$)|(^iv$)|(^b$)
+# Whitelist variable names: iv, b, _b, x, y, r, s
+variable-rgx = ([a-z_][a-z0-9_]{2,30}$)|(^iv$)|(^b$)|(^_b$)|(^x$)|(^y$)|(^r$)|(^s$)
+
+[VARIABLES]
+additional-builtins = raw_input
+
+[DESIGN]
+max-args = 10
+
+[FORMAT]
+max-line-length = 120
+
+[REPORTS]
+msg-template = {path}:{line}: [{msg_id}({symbol}), {obj}] {msg}

examples/src/pylintrc

@@ -1,6 +1,7 @@
 [MESSAGE CONTROL]
 # Disabling messages that either we don't care about we intentionally break.
 disable =
+    import-error, # ignore mpl import errors
     invalid-name,  # we prefer long, descriptive, names for examples
     bad-continuation,  # we let black handle this
     ungrouped-imports,  # we let isort handle this

examples/test/deprecated/pylintrc

@@ -0,0 +1,22 @@
+[MESSAGES CONTROL]
+# Disabling messages that we either don't care about for tests or are necessary to break for tests.
+disable =
+    invalid-name,  # we prefer long, descriptive, names for tests
+    missing-docstring,  # we don't write docstrings for tests
+    wrong-import-position,  # similar to E0401, pylint does not appear to identify
+                            # unknown modules as non-standard-library. flake8 tests for this as well
+                            # and does treat them properly
+    duplicate-code,  # tests for similar things tend to be similar
+    consider-using-f-string # disable until 2022-05-05; 6 months after 3.5 deprecation
+
+[VARIABLES]
+additional-builtins = raw_input
+
+[DESIGN]
+max-args = 10
+
+[FORMAT]
+max-line-length = 120
+
+[REPORTS]
+msg-template = {path}:{line}: [{msg_id}({symbol}), {obj}] {msg}

examples/test/pylintrc

@@ -1,6 +1,7 @@
 [MESSAGES CONTROL]
 # Disabling messages that we either don't care about for tests or are necessary to break for tests.
 disable =
+    import-error, # ignore mpl import errors
     invalid-name,  # we prefer long, descriptive, names for tests
     missing-docstring,  # we don't write docstrings for tests
     wrong-import-position,  # similar to E0401, pylint does not appear to identify

examples/test/test_i_raw_rsa_keyring_example.py

@@ -60,7 +60,7 @@ def test_encrypt_and_decrypt_fails_if_user_provides_only_public_key():
     test both encryption and decryption, or not provide any keys and the example generates both
     """
     # Generate the user keys for testing
-    user_public_key, user_private_key = generate_rsa_keys()
+    user_public_key, user_private_key = generate_rsa_keys()  # pylint: disable=unused-variable
 
     # Convert the public key to string
     user_public_key = user_public_key.decode('utf-8')
@@ -92,7 +92,7 @@ def test_encrypt_and_decrypt_fails_if_user_provides_only_private_key():
     test both encryption and decryption, or not provide any keys and the example generates both
     """
     # Generate the user keys for testing
-    user_public_key, user_private_key = generate_rsa_keys()
+    user_public_key, user_private_key = generate_rsa_keys()  # pylint: disable=unused-variable
 
     # Convert the private key to string
     user_private_key = user_private_key.decode('utf-8')

tox.ini

@@ -192,8 +192,8 @@ commands =
 basepython = {[testenv:pylint]basepython}
 deps = {[testenv:pylint]deps}
 commands =
-    pylint --rcfile=examples/src/pylintrc examples/src/ --ignore-paths=examples/src/keyrings
-    pylint --rcfile=examples/test/pylintrc --disable R0801 examples/test/ --ignore-paths=examples/test/keyrings
+    pylint --rcfile=examples/src/pylintrc examples/src/
+    pylint --rcfile=examples/test/pylintrc --disable R0801 examples/test/
 
 [testenv:pylint-tests]
 basepython = {[testenv:pylint]basepython}