fix: filtering client suppliers MUST check the client region after creation as well as before #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation as well as before
acioc
previously approved these changes
Apr 23, 2020
Comment on lines
+139
to
+157
| def test_deny_region_block_on_response(): | ||
| region = "us-west-2" | ||
| test = DenyRegionsClientSupplier( | ||
| denied_regions=[region], client_supplier=AlwaysOneRegionClientSupplier(region_name=region) | ||
| ) | ||
|
|
||
| # Catch the blocked region on response. | ||
| with pytest.raises(UnknownRegionError): | ||
| test(None) | ||
|
|
||
|
|
||
| def test_allow_region_block_on_response(): | ||
| test = AllowRegionsClientSupplier( | ||
| allowed_regions=[None, "us-west-2"], client_supplier=AlwaysOneRegionClientSupplier(region_name="us-east-2") | ||
| ) | ||
|
|
||
| # Catch the blocked region on response. | ||
| with pytest.raises(UnknownRegionError): | ||
| test(None) |
There was a problem hiding this comment.
Should we also test the positive cases? Passing None but having it be a valid region once it's checked?
There was a problem hiding this comment.
Good call. Additional tests added.
…e requested region is unknown and resolved by underlying client supplier
|
Discarding this change due to upcoming major rework of AWS KMS keyrings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
resolves: #258
Description of changes:
Per #258, this introduces two changes to the filtering client suppliers:
Noneto let users filter out requests when the region is unknownBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: