Skip to content

chore: update pylint settings to match changes in 2.5.0 #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2020
Merged

chore: update pylint settings to match changes in 2.5.0 #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27f7e76
chore: update pylint settings to match changes in 2.5.0
mattsb42-aws Apr 28, 2020
5c35cef
docs: add explanation of why validator function signature is what it is
mattsb42-aws Apr 28, 2020
635bb5c
chore: add full-message-decrypt scenario name into failing error message
mattsb42-aws Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/aws_encryption_sdk/internal/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
pass


def value_is_not_a_string(instance, attribute, value):
# The unused-argument check is disabled because
# this function MUST match the function signature
# for attrs validators.
def value_is_not_a_string(instance, attribute, value): # pylint: disable=unused-argument
# type: (Any, attr.Attribute, Any) -> None
"""Technically a string is an iterable containing strings.

Expand Down
2 changes: 1 addition & 1 deletion test_vector_handlers/src/awses_test_vectors/manifests/full_message/decrypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def run(self, name):
"""
plaintext, _header = aws_encryption_sdk.decrypt(source=self.ciphertext, key_provider=self.master_key_provider)
if plaintext != self.plaintext:
raise ValueError("Decrypted plaintext does not match expected value.")
raise ValueError("Decrypted plaintext does not match expected value for scenario '{}'".format(name))


@attr.s(init=False)
Expand Down