Fixing poor return code flow path and adding test to verify proper return of start task operation.

Author: DavidOgunsAWS

devicedefender/source/DeviceDefender.cpp

@@ -103,6 +103,7 @@ namespace Aws
 
         int ReportTask::StartTask() noexcept
         {
+            int return_code = AWS_OP_ERR;
             if (m_taskConfig != nullptr && !m_lastError &&
                 (this->GetStatus() == ReportTaskStatus::Ready || this->GetStatus() == ReportTaskStatus::Stopped))
             {
@@ -114,14 +115,14 @@ namespace Aws
                 {
                     this->m_lastError = aws_last_error();
                     aws_raise_error(this->m_lastError);
-                    return AWS_OP_ERR;
                 }
                 else
                 {
                     this->m_status = ReportTaskStatus::Running;
+                    return_code = AWS_OP_SUCCESS;
                 }
             }
-            return AWS_OP_ERR;
+            return return_code;
         }
 
         void ReportTask::StopTask() noexcept

devicedefender/tests/DeviceDefenderTest.cpp

@@ -65,7 +65,7 @@ static int s_TestDeviceDefenderResourceSafety(Aws::Crt::Allocator *allocator, vo
 
         ASSERT_INT_EQUALS((int)Aws::Iotdevicedefenderv1::ReportTaskStatus::Ready, (int)task.GetStatus());
 
-        task.StartTask();
+        ASSERT_SUCCESS(task.StartTask());
         ASSERT_INT_EQUALS((int)Aws::Iotdevicedefenderv1::ReportTaskStatus::Running, (int)task.GetStatus());
         task.StopTask();