windowsUser addition to RunInfo (#359)

bretambrose · Bret Ambrose · web-flow · commit 4dc84d47dbb5 · 2021-11-30T13:53:26.000-08:00
* windowsUser addition to RunInfo
* Add secure_tunneling to formatting

Co-authored-by: Bret Ambrose &lt;bambrose@amazon.com&gt;
diff --git a/eventstream_rpc/tests/include/awstest/EchoTestRpcClient.h b/eventstream_rpc/tests/include/awstest/EchoTestRpcClient.h
@@ -26,12 +26,10 @@ namespace Awstest
             Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
         /**
          * Connect the client to the server
-         * @param lifecycleHandler An interface that is called upon when lifecycle
-         * events relating to the connection occur.
-         * @param connectionConfig The configuration parameters used for establishing
-         * the connection.
-         * @return An `RpcError` that can be used to check whether the connection was
-         * established.
+         * @param lifecycleHandler An interface that is called upon when lifecycle events relating to the connection
+         * occur.
+         * @param connectionConfig The configuration parameters used for establishing the connection.
+         * @return An `RpcError` that can be used to check whether the connection was established.
          */
         std::future<RpcError> Connect(
             ConnectionLifecycleHandler &lifecycleHandler,
diff --git a/eventstream_rpc/tests/include/awstest/EchoTestRpcModel.h b/eventstream_rpc/tests/include/awstest/EchoTestRpcModel.h
@@ -61,8 +61,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(Customer *) noexcept;
-        /* This needs to be defined so that `Customer` can be used as a key in maps.
-         */
+        /* This needs to be defined so that `Customer` can be used as a key in maps. */
         bool operator<(const Customer &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -157,8 +156,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(MessageData *) noexcept;
-        /* This needs to be defined so that `MessageData` can be used as a key in
-         * maps. */
+        /* This needs to be defined so that `MessageData` can be used as a key in maps. */
         bool operator<(const MessageData &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -221,8 +219,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(EchoStreamingMessage *) noexcept;
-        /* This needs to be defined so that `EchoStreamingMessage` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `EchoStreamingMessage` can be used as a key in maps. */
         bool operator<(const EchoStreamingMessage &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -252,8 +249,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(GetAllProductsResponse *) noexcept;
-        /* This needs to be defined so that `GetAllProductsResponse` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `GetAllProductsResponse` can be used as a key in maps. */
         bool operator<(const GetAllProductsResponse &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -275,8 +271,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(GetAllProductsRequest *) noexcept;
-        /* This needs to be defined so that `GetAllProductsRequest` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `GetAllProductsRequest` can be used as a key in maps. */
         bool operator<(const GetAllProductsRequest &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -299,8 +294,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(GetAllCustomersResponse *) noexcept;
-        /* This needs to be defined so that `GetAllCustomersResponse` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `GetAllCustomersResponse` can be used as a key in maps. */
         bool operator<(const GetAllCustomersResponse &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -322,8 +316,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(GetAllCustomersRequest *) noexcept;
-        /* This needs to be defined so that `GetAllCustomersRequest` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `GetAllCustomersRequest` can be used as a key in maps. */
         bool operator<(const GetAllCustomersRequest &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -346,8 +339,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(EchoMessageResponse *) noexcept;
-        /* This needs to be defined so that `EchoMessageResponse` can be used as a key
-         * in maps. */
+        /* This needs to be defined so that `EchoMessageResponse` can be used as a key in maps. */
         bool operator<(const EchoMessageResponse &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -371,8 +363,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(EchoMessageRequest *) noexcept;
-        /* This needs to be defined so that `EchoMessageRequest` can be used as a key
-         * in maps. */
+        /* This needs to be defined so that `EchoMessageRequest` can be used as a key in maps. */
         bool operator<(const EchoMessageRequest &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -394,8 +385,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(EchoStreamingResponse *) noexcept;
-        /* This needs to be defined so that `EchoStreamingResponse` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `EchoStreamingResponse` can be used as a key in maps. */
         bool operator<(const EchoStreamingResponse &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -416,8 +406,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(EchoStreamingRequest *) noexcept;
-        /* This needs to be defined so that `EchoStreamingRequest` can be used as a
-         * key in maps. */
+        /* This needs to be defined so that `EchoStreamingRequest` can be used as a key in maps. */
         bool operator<(const EchoStreamingRequest &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -442,8 +431,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(ServiceError *) noexcept;
-        /* This needs to be defined so that `ServiceError` can be used as a key in
-         * maps. */
+        /* This needs to be defined so that `ServiceError` can be used as a key in maps. */
         bool operator<(const ServiceError &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -466,8 +454,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(CauseServiceErrorResponse *) noexcept;
-        /* This needs to be defined so that `CauseServiceErrorResponse` can be used as
-         * a key in maps. */
+        /* This needs to be defined so that `CauseServiceErrorResponse` can be used as a key in maps. */
         bool operator<(const CauseServiceErrorResponse &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -488,8 +475,7 @@ namespace Awstest
             Aws::Crt::StringView,
             Aws::Crt::Allocator *) noexcept;
         static void s_customDeleter(CauseServiceErrorRequest *) noexcept;
-        /* This needs to be defined so that `CauseServiceErrorRequest` can be used as
-         * a key in maps. */
+        /* This needs to be defined so that `CauseServiceErrorRequest` can be used as a key in maps. */
         bool operator<(const CauseServiceErrorRequest &) const noexcept;
         static const char *MODEL_NAME;
 
@@ -547,10 +533,8 @@ namespace Awstest
         /**
          * Used to activate a stream for the `GetAllProductsOperation`
          * @param request The request used for the `GetAllProductsOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const GetAllProductsRequest &request,
@@ -612,10 +596,8 @@ namespace Awstest
         /**
          * Used to activate a stream for the `CauseServiceErrorOperation`
          * @param request The request used for the `CauseServiceErrorOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const CauseServiceErrorRequest &request,
@@ -635,10 +617,8 @@ namespace Awstest
         virtual void OnStreamEvent(EchoStreamingMessage *response) { (void)response; }
 
         /**
-         * A callback that is invoked when an error occurs while parsing a message
-         * from the stream.
-         * @param rpcError The RPC error containing the status and possibly a CRT
-         * error.
+         * A callback that is invoked when an error occurs while parsing a message from the stream.
+         * @param rpcError The RPC error containing the status and possibly a CRT error.
          */
         virtual bool OnStreamError(RpcError rpcError)
         {
@@ -657,8 +637,7 @@ namespace Awstest
         }
 
         /**
-         * A callback that is invoked upon receiving ANY error response from the
-         * server.
+         * A callback that is invoked upon receiving ANY error response from the server.
          * @param operationError The error message being received.
          */
         virtual bool OnStreamError(OperationError *operationError)
@@ -673,8 +652,7 @@ namespace Awstest
          */
         void OnStreamEvent(Aws::Crt::ScopedResource<AbstractShapeBase> response) override;
         /**
-         * Invoked when a message is received on this continuation but results in an
-         * error.
+         * Invoked when a message is received on this continuation but results in an error.
          *
          * This callback can return true so that the stream is closed afterwards.
          */
@@ -730,12 +708,9 @@ namespace Awstest
             Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
         /**
          * Used to activate a stream for the `CauseStreamServiceToErrorOperation`
-         * @param request The request used for the
-         * `CauseStreamServiceToErrorOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param request The request used for the `CauseStreamServiceToErrorOperation`
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const EchoStreamingRequest &request,
@@ -755,10 +730,8 @@ namespace Awstest
         virtual void OnStreamEvent(EchoStreamingMessage *response) { (void)response; }
 
         /**
-         * A callback that is invoked when an error occurs while parsing a message
-         * from the stream.
-         * @param rpcError The RPC error containing the status and possibly a CRT
-         * error.
+         * A callback that is invoked when an error occurs while parsing a message from the stream.
+         * @param rpcError The RPC error containing the status and possibly a CRT error.
          */
         virtual bool OnStreamError(RpcError rpcError)
         {
@@ -767,8 +740,7 @@ namespace Awstest
         }
 
         /**
-         * A callback that is invoked upon receiving ANY error response from the
-         * server.
+         * A callback that is invoked upon receiving ANY error response from the server.
          * @param operationError The error message being received.
          */
         virtual bool OnStreamError(OperationError *operationError)
@@ -783,8 +755,7 @@ namespace Awstest
          */
         void OnStreamEvent(Aws::Crt::ScopedResource<AbstractShapeBase> response) override;
         /**
-         * Invoked when a message is received on this continuation but results in an
-         * error.
+         * Invoked when a message is received on this continuation but results in an error.
          *
          * This callback can return true so that the stream is closed afterwards.
          */
@@ -839,10 +810,8 @@ namespace Awstest
         /**
          * Used to activate a stream for the `EchoStreamMessagesOperation`
          * @param request The request used for the `EchoStreamMessagesOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const EchoStreamingRequest &request,
@@ -904,10 +873,8 @@ namespace Awstest
         /**
          * Used to activate a stream for the `EchoMessageOperation`
          * @param request The request used for the `EchoMessageOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const EchoMessageRequest &request,
@@ -969,10 +936,8 @@ namespace Awstest
         /**
          * Used to activate a stream for the `GetAllCustomersOperation`
          * @param request The request used for the `GetAllCustomersOperation`
-         * @param onMessageFlushCallback An optional callback that is invoked when the
-         * request is flushed.
-         * @return An `RpcError` that can be used to check whether the stream was
-         * activated.
+         * @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
+         * @return An `RpcError` that can be used to check whether the stream was activated.
          */
         std::future<RpcError> Activate(
             const GetAllCustomersRequest &request,
diff --git a/format-check.sh b/format-check.sh
@@ -10,7 +10,7 @@ if NOT type $CLANG_FORMAT 2> /dev/null ; then
 fi
 
 FAIL=0
-SOURCE_FILES=`find devicedefender discovery eventstream_rpc greengrass_ipc identity iotdevicecommon jobs shadow samples -type f \( -name '*.h' -o -name '*.cpp' \)`
+SOURCE_FILES=`find devicedefender discovery eventstream_rpc greengrass_ipc identity iotdevicecommon jobs shadow samples secure_tunneling -type f \( -name '*.h' -o -name '*.cpp' \)`
 for i in $SOURCE_FILES
 do
     $CLANG_FORMAT -output-replacements-xml $i | grep -c "<replacement " > /dev/null
diff --git a/greengrass_ipc/include/aws/greengrass/GreengrassCoreIpcClient.h b/greengrass_ipc/include/aws/greengrass/GreengrassCoreIpcClient.h
@@ -28,12 +28,10 @@ namespace Aws
                 Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
             /**
              * Connect the client to the server
-             * @param lifecycleHandler An interface that is called upon when lifecycle
-             * events relating to the connection occur.
-             * @param connectionConfig The configuration parameters used for establishing
-             * the connection.
-             * @return An `RpcError` that can be used to check whether the connection was
-             * established.
+             * @param lifecycleHandler An interface that is called upon when lifecycle events relating to the connection
+             * occur.
+             * @param connectionConfig The configuration parameters used for establishing the connection.
+             * @return An `RpcError` that can be used to check whether the connection was established.
              */
             std::future<RpcError> Connect(
                 ConnectionLifecycleHandler &lifecycleHandler,
diff --git a/greengrass_ipc/include/aws/greengrass/GreengrassCoreIpcModel.h b/greengrass_ipc/include/aws/greengrass/GreengrassCoreIpcModel.h
diff --git a/greengrass_ipc/source/GreengrassCoreIpcModel.cpp b/greengrass_ipc/source/GreengrassCoreIpcModel.cpp
