Skip to content

Commit 0f8f433

Browse files
authored
chore: Move to ruff from pylint (#435)
When we started the project we defaulted to use pylint. Pylint has served it's purpose but it pretty slow. Ruff is a newer linter in the python ecosystem but is written in Rust. This makes Ruff was faster than pylint. On my machine (while testing in SAM CLI), pylint took about 70s to lint the repo but with ruff it took .04s. Co-authored-by: Jacob Fuss <[email protected]>
1 parent 02b03aa commit 0f8f433

File tree

16 files changed

+19
-382
lines changed

16 files changed

+19
-382
lines changed

.pylintrc

Lines changed: 0 additions & 365 deletions
This file was deleted.

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ integ-test:
1515

1616
lint:
1717
# Liner performs static analysis to catch latent bugs
18-
pylint --rcfile .pylintrc aws_lambda_builders
18+
ruff aws_lambda_builders
1919

2020
# Command to run everytime you make changes to verify everything works
2121
dev: lint test

aws_lambda_builders/builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import os
77
import logging
88

9-
from aws_lambda_builders.architecture import X86_64, ARM64
9+
from aws_lambda_builders.architecture import X86_64
1010
from aws_lambda_builders.registry import get_workflow, DEFAULT_REGISTRY
1111
from aws_lambda_builders.workflow import Capability
1212

aws_lambda_builders/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from pathlib import Path
1010
from typing import Union
1111

12-
from aws_lambda_builders.architecture import X86_64, ARM64
12+
from aws_lambda_builders.architecture import ARM64
1313

1414
LOG = logging.getLogger(__name__)
1515

0 commit comments

Comments
 (0)