WIP: Golang workflow using "dep" dependency manager #47
Conversation
| The workflow does the following: | ||
| 1. Check for manifest **Gopkg.toml** | ||
| 2. Install dependencies using `dep ensure -v` | ||
| 3. Compile using `GOOS=linux GOARCH=amd64 go build -ldflags="-s -w" -o $ARTIFACT_DIR/$HANDLER $SOURCE_DIR` |
There was a problem hiding this comment.
One question I have is what are the goals for the sam build command. I would love to use a command like this in my workflow, but what if I already have well defined build steps as part of a Makefile in my repo? Make and Makefiles are a pretty common construct within Golang. Could we do something simpler where we just call make build? That way if developers want slightly different arguments, or multiple steps they can still use the sam build api. Maybe this make file could be generated if it is not present the first time.
There was a problem hiding this comment.
@roryj Right now we want to support the dependency managers directly with good defaults (python, node, and ruby follow this) and then allow/expand to different arguments/multiple step workflows in the future.
|
#54 Was started from this and expanded upon it, also contains the implementation. Closing this in favor of that one. |
Description of changes:
Starting with a design document to communicate what I am building. Will add implementation soon.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.