Golang Dep Builder #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
suggested changes
Dec 21, 2018
jfuss
suggested changes
Jan 2, 2019
tests/integration/workflows/go_dep/data/src/remote-deps/Gopkg.toml
Outdated
Show resolved
Hide resolved
|
@sthulb Can you rebase so we can get the build passing (you fixed the appveyor ruby in a different pr)? I will make a pass at the PR now as well. |
jfuss
suggested changes
Jan 4, 2019
|
I'm not quite sure why ruby tests are failing for my build... I've not touched ruby in anyway in this branch. The good news is, the Go tests all passed. |
jfuss
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.