Skip to content

fix: Symlinks to non-existent directories, symlinks re-creating #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2023
Merged

fix: Symlinks to non-existent directories, symlinks re-creating #578

merged 5 commits into from
Nov 21, 2023

Conversation

mildaniel
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
There are two scenarios fixed by this PR:

  1. The symbolic link action attempts to link to a non-existent directory. This results in an error when executing sam package.
  2. The symbolic link utility function attempts to link to an already created directory resulting in an error when using auto-dependency layer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner November 20, 2023 21:28
mndeveci
mndeveci reviewed Nov 21, 2023
View reviewed changes
@mildaniel mildaniel added this pull request to the merge queue Nov 21, 2023
Merged via the queue into aws:develop with commit 5aab974 Nov 21, 2023
@mildaniel mildaniel deleted the fix-symlinking-nodejs branch November 21, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndeveci mndeveci mndeveci approved these changes

@lucashuy lucashuy lucashuy approved these changes

@moelasmar moelasmar Awaiting requested review from moelasmar moelasmar was automatically assigned from aws/serverless-application-experience-sbt

@jysheng123 jysheng123 Awaiting requested review from jysheng123 jysheng123 was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mildaniel @mndeveci @lucashuy