Skip to content

Commit 8fefcd7

Browse files
authored
Remove RequiresPreviewFeatures attribute from logging APIs (#1862)
1 parent d7d8ebe commit 8fefcd7

File tree

3 files changed

+11
-30
lines changed

3 files changed

+11
-30
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"Projects": [
3+
{
4+
"Name": "Amazon.Lambda.Core",
5+
"Type": "Minor",
6+
"ChangelogMessages": [
7+
"Removed RequiresPreviewFeatures attribute from parameterized logging APIs"
8+
]
9+
}
10+
]
11+
}

Libraries/src/Amazon.Lambda.Core/ILambdaLogger.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,6 @@ public interface ILambdaLogger
147147
void LogCritical(string message) => Log(LogLevel.Critical.ToString(), message);
148148

149149

150-
private const string ParameterizedPreviewMessage =
151-
"Parameterized logging is in preview till a new version of .NET Lambda runtime client that supports parameterized logging " +
152-
"has been deployed to the .NET Lambda managed runtime. Till deployment has been made the feature can be used by deploying as an " +
153-
"executable including the latest version of Amazon.Lambda.RuntimeSupport and setting the \"EnablePreviewFeatures\" in the Lambda " +
154-
"project file to \"true\"";
155-
156150
/// <summary>
157151
/// Log message categorized by the given log level
158152
/// <para>
@@ -163,7 +157,6 @@ public interface ILambdaLogger
163157
/// <param name="level">Log level of the message.</param>
164158
/// <param name="message">Message to log.</param>
165159
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
166-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
167160
void Log(string level, string message, params object[] args) => Log(level, message, args);
168161

169162
/// <summary>
@@ -177,7 +170,6 @@ public interface ILambdaLogger
177170
/// <param name="exception">Exception to include with the logging.</param>
178171
/// <param name="message">Message to log.</param>
179172
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
180-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
181173
void Log(string level, Exception exception, string message, params object[] args)
182174
{
183175
Log(level, message, args);
@@ -194,7 +186,6 @@ void Log(string level, Exception exception, string message, params object[] args
194186
/// <param name="level">Log level of the message.</param>
195187
/// <param name="message">Message to log.</param>
196188
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
197-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
198189
void Log(LogLevel level, string message, params object[] args) => Log(level.ToString(), message, args);
199190

200191
/// <summary>
@@ -208,7 +199,6 @@ void Log(string level, Exception exception, string message, params object[] args
208199
/// <param name="exception">Exception to include with the logging.</param>
209200
/// <param name="message">Message to log.</param>
210201
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
211-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
212202
void Log(LogLevel level, Exception exception, string message, params object[] args) => Log(level.ToString(), exception, message, args);
213203

214204
/// <summary>
@@ -220,7 +210,6 @@ void Log(string level, Exception exception, string message, params object[] args
220210
/// </summary>
221211
/// <param name="message">Message to log.</param>
222212
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
223-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
224213
void LogTrace(string message, params object[] args) => Log(LogLevel.Trace.ToString(), message, args);
225214

226215
/// <summary>
@@ -233,7 +222,6 @@ void Log(string level, Exception exception, string message, params object[] args
233222
/// <param name="exception">Exception to include with the logging.</param>
234223
/// <param name="message">Message to log.</param>
235224
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
236-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
237225
void LogTrace(Exception exception, string message, params object[] args) => Log(LogLevel.Trace.ToString(), exception, message, args);
238226

239227
/// <summary>
@@ -245,7 +233,6 @@ void Log(string level, Exception exception, string message, params object[] args
245233
/// </summary>
246234
/// <param name="message">Message to log.</param>
247235
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
248-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
249236
void LogDebug(string message, params object[] args) => Log(LogLevel.Debug.ToString(), message, args);
250237

251238
/// <summary>
@@ -258,7 +245,6 @@ void Log(string level, Exception exception, string message, params object[] args
258245
/// <param name="exception">Exception to include with the logging.</param>
259246
/// <param name="message">Message to log.</param>
260247
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
261-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
262248
void LogDebug(Exception exception, string message, params object[] args) => Log(LogLevel.Debug.ToString(), exception, message, args);
263249

264250
/// <summary>
@@ -270,7 +256,6 @@ void Log(string level, Exception exception, string message, params object[] args
270256
/// </summary>
271257
/// <param name="message">Message to log.</param>
272258
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
273-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
274259
void LogInformation(string message, params object[] args) => Log(LogLevel.Information.ToString(), message, args);
275260

276261
/// <summary>
@@ -283,7 +268,6 @@ void Log(string level, Exception exception, string message, params object[] args
283268
/// <param name="exception">Exception to include with the logging.</param>
284269
/// <param name="message">Message to log.</param>
285270
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
286-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
287271
void LogInformation(Exception exception, string message, params object[] args) => Log(LogLevel.Information.ToString(), exception, message, args);
288272

289273
/// <summary>
@@ -295,7 +279,6 @@ void Log(string level, Exception exception, string message, params object[] args
295279
/// </summary>
296280
/// <param name="message">Message to log.</param>
297281
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
298-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
299282
void LogWarning(string message, params object[] args) => Log(LogLevel.Warning.ToString(), message, args);
300283

301284
/// <summary>
@@ -308,7 +291,6 @@ void Log(string level, Exception exception, string message, params object[] args
308291
/// <param name="exception">Exception to include with the logging.</param>
309292
/// <param name="message">Message to log.</param>
310293
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
311-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
312294
void LogWarning(Exception exception, string message, params object[] args) => Log(LogLevel.Warning.ToString(), exception, message, args);
313295

314296
/// <summary>
@@ -320,7 +302,6 @@ void Log(string level, Exception exception, string message, params object[] args
320302
/// </summary>
321303
/// <param name="message">Message to log.</param>
322304
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
323-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
324305
void LogError(string message, params object[] args) => Log(LogLevel.Error.ToString(), message, args);
325306

326307
/// <summary>
@@ -333,7 +314,6 @@ void Log(string level, Exception exception, string message, params object[] args
333314
/// <param name="exception">Exception to include with the logging.</param>
334315
/// <param name="message">Message to log.</param>
335316
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
336-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
337317
void LogError(Exception exception, string message, params object[] args) => Log(LogLevel.Error.ToString(), exception, message, args);
338318

339319
/// <summary>
@@ -345,7 +325,6 @@ void Log(string level, Exception exception, string message, params object[] args
345325
/// </summary>
346326
/// <param name="message">Message to log.</param>
347327
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
348-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
349328
void LogCritical(string message, params object[] args) => Log(LogLevel.Critical.ToString(), message, args);
350329

351330
/// <summary>
@@ -358,7 +337,6 @@ void Log(string level, Exception exception, string message, params object[] args
358337
/// <param name="exception">Exception to include with the logging.</param>
359338
/// <param name="message">Message to log.</param>
360339
/// <param name="args">Values to be replaced in log messages that are parameterized.</param>
361-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
362340
void LogCritical(Exception exception, string message, params object[] args) => Log(LogLevel.Critical.ToString(), exception, message, args);
363341

364342
#endif

Libraries/src/Amazon.Lambda.RuntimeSupport/Context/LambdaConsoleLogger.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,11 @@ public void Log(string level, string message)
4646
_consoleLoggerRedirector.FormattedWriteLine(level, message);
4747
}
4848

49-
private const string ParameterizedPreviewMessage =
50-
"Parameterized logging is in preview till a new version of .NET Lambda runtime client that supports parameterized logging " +
51-
"has been deployed to the .NET Lambda managed runtime. Till deployment has been made the feature can be used by deploying as an " +
52-
"executable including the latest version of Amazon.Lambda.RuntimeSupport and setting the \"LangVersion\" in the Lambda " +
53-
"project file to \"preview\"";
54-
55-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
5649
public void Log(string level, string message, params object[] args)
5750
{
5851
_consoleLoggerRedirector.FormattedWriteLine(level, message, args);
5952
}
6053

61-
[RequiresPreviewFeatures(ParameterizedPreviewMessage)]
6254
public void Log(string level, Exception exception, string message, params object[] args)
6355
{
6456
_consoleLoggerRedirector.FormattedWriteLine(level, exception, message, args);

0 commit comments

Comments
 (0)