Skip to content

Commit d4203ee

Browse files
committed
respond to feedback
1 parent a7b9cc0 commit d4203ee

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed

Tools/LambdaTestTool-v2/tests/Amazon.Lambda.TestTool.IntegrationTests/ApiGatewayEmulatorProcessTests.cs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ public ApiGatewayEmulatorProcessTests(ITestOutputHelper testOutputHelper)
2929
_testOutputHelper = testOutputHelper;
3030
}
3131

32+
#if DEBUG
33+
[Fact]
34+
#else
3235
[Fact(Skip = "Skipping this test as it is not working properly.")]
36+
#endif
3337
public async Task TestLambdaToUpperV2()
3438
{
3539
var lambdaPort = 6012;
@@ -64,7 +68,11 @@ public async Task TestLambdaToUpperV2()
6468
}
6569
}
6670

71+
#if DEBUG
72+
[Fact]
73+
#else
6774
[Fact(Skip = "Skipping this test as it is not working properly.")]
75+
#endif
6876
public async Task TestLambdaToUpperRest()
6977
{
7078
var lambdaPort = 6010;
@@ -99,7 +107,11 @@ public async Task TestLambdaToUpperRest()
99107
}
100108
}
101109

110+
#if DEBUG
111+
[Fact]
112+
#else
102113
[Fact(Skip = "Skipping this test as it is not working properly.")]
114+
#endif
103115
public async Task TestLambdaToUpperV1()
104116
{
105117
var lambdaPort = 6008;
@@ -134,7 +146,11 @@ public async Task TestLambdaToUpperV1()
134146
}
135147
}
136148

149+
#if DEBUG
150+
[Fact]
151+
#else
137152
[Fact(Skip = "Skipping this test as it is not working properly.")]
153+
#endif
138154
public async Task TestLambdaBinaryResponse()
139155
{
140156
var lambdaPort = 6006;
@@ -175,7 +191,11 @@ public async Task TestLambdaBinaryResponse()
175191
}
176192
}
177193

194+
#if DEBUG
195+
[Fact]
196+
#else
178197
[Fact(Skip = "Skipping this test as it is not working properly.")]
198+
#endif
179199
public async Task TestLambdaReturnString()
180200
{
181201
var lambdaPort = 6004;
@@ -210,7 +230,11 @@ public async Task TestLambdaReturnString()
210230
}
211231
}
212232

233+
#if DEBUG
234+
[Fact]
235+
#else
213236
[Fact(Skip = "Skipping this test as it is not working properly.")]
237+
#endif
214238
public async Task TestLambdaWithNullEndpoint()
215239
{
216240
var testProjectDir = Path.GetFullPath("../../../../../testapps");

Tools/LambdaTestTool-v2/tests/Amazon.Lambda.TestTool.UnitTests/PackagingTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ private string GetRuntimeSupportTargetFrameworks()
5656
return output.Trim();
5757
}
5858

59+
#if DEBUG
60+
[Fact]
61+
#else
5962
[Fact(Skip = "Skipping this test as it is not working properly.")]
63+
#endif
6064
public void VerifyPackageContentsHasRuntimeSupport()
6165
{
6266
var projectPath = Path.Combine(_workingDirectory, "Tools", "LambdaTestTool-v2", "src", "Amazon.Lambda.TestTool", "Amazon.Lambda.TestTool.csproj");

buildtools/build.proj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@
201201
<Target Name="run-integ-tests">
202202
<Exec Command="dotnet test -c $(Configuration) --logger &quot;console;verbosity=detailed&quot;" WorkingDirectory="..\Libraries\test\Amazon.Lambda.RuntimeSupport.Tests\Amazon.Lambda.RuntimeSupport.IntegrationTests"/>
203203
<Exec Command="dotnet test -c $(Configuration) --logger &quot;console;verbosity=detailed&quot;" WorkingDirectory="..\Libraries\test\TestServerlessApp.IntegrationTests"/>
204-
<Exec Command="dotnet test -c $(Configuration) --logger &quot;console;verbosity=detailed&quot;" WorkingDirectory="..\Tools\LambdaTestTool-v2\tests\Amazon.Lambda.TestTool.IntegrationTests"/>
205204
</Target>
206205
<Target Name="create-nuget-packages-cicd" DependsOnTargets="build-project-packages">
207206
<Exec Command="$(PackCommand)" WorkingDirectory="..\Libraries\src\%(LibraryName.FileName)"/>

buildtools/ci.buildspec.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@ phases:
1313
build:
1414
commands:
1515
- dotnet test -c Release --logger "console;verbosity=detailed" ./Tools/LambdaTestTool-v2/tests/Amazon.Lambda.TestTool.UnitTests/Amazon.Lambda.TestTool.UnitTests.csproj
16+
- dotnet test -c Release --logger "console;verbosity=detailed" ./Tools/LambdaTestTool-v2/tests/Amazon.Lambda.TestTool.IntegrationTests/Amazon.Lambda.TestTool.IntegrationTests.csproj
1617
- dotnet msbuild buildtools/build.proj /t:unit-tests /p:Cicd=true
1718
- dotnet msbuild buildtools/build.proj /t:integ-tests /p:Cicd=true

0 commit comments

Comments
 (0)