Breaking Change: Move all APIGateway attributes to a their own namespace #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace Amazon.Lambda.Annotations.APIGateway
ganeshnj
approved these changes
Aug 1, 2022
philasmar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There is concern as we add more service support for special events like we have for API Gateway that having all of those attributes at the root namespace of Amazon.Lambda.Annotations will cause too much clutter and possibly conflict in this namespace.
This PR makes a breaking change, while we are still in preview, to move all of the API Gateway specific attributes to the
Amazon.Lambda.Annotations.APIGatewaynamespace.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.