Skip to content

Remove Annotation nuspec file #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

philasmar
Copy link
Contributor

@philasmar philasmar commented Oct 21, 2024

Description of changes:

  • Remove Annotation's library nuspec file and replace with a regular dotnet build of the Amazon.Lambda.Annotations.SourceGenerator project to produce the Amazon.Lambda.Annotations package.
  • Update tests to automatically replace the version of the Amazon.Lambda.Annotations.SourceGenerator project instead of needing to manually update them every time there is a version bump.
  • Add the .NET8 target with trimming to the NuGet package as it was not previously added
  • Removed dev preview text from the package description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested a review from normj October 21, 2024 13:36
@philasmar philasmar force-pushed the asmarp/annotations-no-nuspec branch from 08c78db to 7a00641 Compare October 22, 2024 03:05
@philasmar philasmar requested a review from 96malhar October 22, 2024 03:10
@philasmar philasmar marked this pull request as ready for review October 22, 2024 03:10
@philasmar philasmar requested a review from normj October 24, 2024 17:00
@philasmar philasmar changed the base branch from master to feature/remove-nuspecs October 25, 2024 13:32
@philasmar philasmar merged commit 3876b5a into feature/remove-nuspecs Oct 25, 2024
4 checks passed
philasmar added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants