Skip to content

Aspire tweaks for test tool #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

Aspire tweaks for test tool #1948

merged 2 commits into from
Jan 28, 2025

Conversation

normj
Copy link
Member

@normj normj commented Jan 28, 2025

Description of changes:
Some tweaks to the test tool for the Aspire integrations:

  • Make starting Lambda runtime an opt-in by setting port
  • Change the opt-in mechanism for API Gateway emulator to be triggered by port for consistency
  • Add a query string parameter on the UI home page to allow preselecting a function in the drop down box
  • Rename --api-gateway-emulator to --api-gateway-emulator-mode because --api-gateway-emulator doesn't give a sense what it is for.
  • Remove the default ports. In the future we might consider an auto port mode for the Lambda port.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj added the Release Not Needed Add this label if a PR does not need to be released. label Jan 28, 2025
@normj normj merged commit 7c44dac into feature/lambdatesttool-v2 Jan 28, 2025
3 of 6 checks passed
@normj normj deleted the normj/aspire-integration branch January 28, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philasmar philasmar philasmar approved these changes

Assignees
No one assigned
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normj @philasmar