Skip to content

Hide documentation banner for configuring Lambda functions when tool is hosted by Aspire #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

normj
Copy link
Member

@normj normj commented Jan 29, 2025

Description of changes:
The banner on the home page explaining how to set the environment variable for lambda runtime API doesn't make sense when used from Aspire because Aspire takes care of all of that setup. This PR adds a utility method that detects when the tool is hosted by an Aspire and then uses that to hide the banner.

This commit in the Aspire repo is where the environment variable is set. aws/integrations-on-dotnet-aspire-for-aws@f12a0a0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj requested review from philasmar and a user January 29, 2025 08:20
@normj normj added the Release Not Needed Add this label if a PR does not need to be released. label Jan 29, 2025
@normj normj merged commit c6dc7d8 into feature/lambdatesttool-v2 Jan 30, 2025
3 of 6 checks passed
@normj normj deleted the normj/add-aspired-hosted branch January 30, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant