Skip to content

SQS Monitor should handle all kinds of InvalidInstanceID errors #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

guessi
Copy link
Contributor

@guessi guessi commented Jul 9, 2024

Fixes: #1034

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@guessi guessi requested a review from a team as a code owner July 9, 2024 02:29
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jul 24, 2024
@guessi
Copy link
Contributor Author

guessi commented Jul 25, 2024

No, it's not stale, remove the label!

@LikithaVemulapalli LikithaVemulapalli added stalebot-ignore To NOT let the stalebot update or close the Issue / PR and removed stale Issues / PRs with no activity labels Jul 25, 2024
Copy link

@steveshidev steveshidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will have a follow up PR to properly handle the ARN sent in the NodeInfo.

@LikithaVemulapalli LikithaVemulapalli merged commit f094c08 into aws:main Jul 31, 2024
14 checks passed
@guessi guessi deleted the handle-InvalidInstanceID branch July 31, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS Monitor should handle all kinds of InvalidInstanceID errors
3 participants