Fix the retry condition to just look for the initial cause

Author: sugmanue

core/retries-api/src/main/java/software/amazon/awssdk/retries/api/RetryStrategy.java

@@ -127,11 +127,10 @@ default B retryOnExceptionOrCause(Class<? extends Throwable> throwable) {
                     return true;
                 }
                 Throwable cause = t.getCause();
-                while (cause != null) {
+                if (cause != null) {
                     if (cause.getClass() == throwable) {
                         return true;
                     }
-                    cause = cause.getCause();
                 }
                 return false;
             });
@@ -147,11 +146,10 @@ default B retryOnExceptionOrCauseInstanceOf(Class<? extends Throwable> throwable
                     return true;
                 }
                 Throwable cause = t.getCause();
-                while (cause != null) {
+                if (cause != null) {
                     if (throwable.isAssignableFrom(cause.getClass())) {
                         return true;
                     }
-                    cause = cause.getCause();
                 }
                 return false;
             });

core/retries-api/src/test/java/software/amazon/awssdk/retries/api/RetryStrategyBuilderTest.java

@@ -58,11 +58,7 @@ static Collection<TestCase> parameters() {
                 .expectShouldRetry()
             , new TestCase()
                 .configure(b -> b.retryOnExceptionOrCause(IllegalArgumentException.class))
-                .givenThrowable(new RuntimeException(new RuntimeException(new IllegalArgumentException())))
-                .expectShouldRetry()
-            , new TestCase()
-                .configure(b -> b.retryOnExceptionOrCause(IllegalArgumentException.class))
-                .givenThrowable(new RuntimeException(new RuntimeException(new NumberFormatException())))
+                .givenThrowable(new RuntimeException(new NumberFormatException()))
                 .expectShouldNotRetry()
             , new TestCase()
                 .configure(b -> b.retryOnExceptionInstanceOf(IllegalArgumentException.class))
@@ -96,10 +92,6 @@ static Collection<TestCase> parameters() {
                 .configure(b -> b.retryOnExceptionOrCauseInstanceOf(IllegalArgumentException.class))
                 .givenThrowable(new NumberFormatException())
                 .expectShouldRetry()
-            , new TestCase()
-                .configure(b -> b.retryOnExceptionOrCauseInstanceOf(IllegalArgumentException.class))
-                .givenThrowable(new RuntimeException(new RuntimeException(new NumberFormatException())))
-                .expectShouldRetry()
         );
     }