Enable & fix inspection: Explicit argument can be lambda (#2821)

Reports method calls that accept a non-trivial expression and can be
replaced with an equivalent method call which accepts a lambda instead.

Converting an expression to a lambda ensures that the expression won't
be evaluated if it's not used inside the method. For example, `optional
.orElse(createDefaultValue())` can be converted to `optional.orElseGet
(this::createDefaultValue)`.

Author: Bennett-Lynch

.idea/inspectionProfiles/AWS_Java_SDK_2_0.xml

@@ -45,8 +45,8 @@ private ProfileFileLocation() {
     public static Path configurationFilePath() {
         return resolveProfileFilePath(
             ProfileFileSystemSetting.AWS_CONFIG_FILE.getStringValue()
-                                                    .orElse(Paths.get(userHomeDirectory(),
-                                                                      ".aws", "config").toString()));
+                                                    .orElseGet(() -> Paths.get(userHomeDirectory(),
+                                                                               ".aws", "config").toString()));
     }
 
     /**
@@ -57,8 +57,8 @@ public static Path configurationFilePath() {
     public static Path credentialsFilePath() {
         return resolveProfileFilePath(
             ProfileFileSystemSetting.AWS_SHARED_CREDENTIALS_FILE.getStringValue()
-                                                                .orElse(Paths.get(userHomeDirectory(),
-                                                                                  ".aws", "credentials").toString()));
+                                                                .orElseGet(() -> Paths.get(userHomeDirectory(),
+                                                                                           ".aws", "credentials").toString()));
     }
 
     /**

core/profiles/src/main/java/software/amazon/awssdk/profiles/ProfileFileLocation.java

@@ -284,7 +284,7 @@ private static int findEarliestMatch(String line, String... searchPatterns) {
                      .mapToInt(line::indexOf)
                      .filter(location -> location >= 0)
                      .min()
-                     .orElse(line.length());
+                     .orElseGet(line::length);
     }
 
     private static boolean isEmptyLine(String line) {

core/profiles/src/main/java/software/amazon/awssdk/profiles/internal/ProfileFileReader.java

@@ -172,7 +172,7 @@ private String getMessage(XmlElement errorRoot) {
      */
     private String getRequestId(SdkHttpFullResponse response, XmlElement document) {
         XmlElement requestId = document.getOptionalElementByName("RequestId")
-                                       .orElse(document.getElementByName("RequestID"));
+                                       .orElseGet(() -> document.getElementByName("RequestID"));
         return requestId != null ?
                requestId.textContent() :
                matchRequestIdHeaders(response);

core/protocols/aws-query-protocol/src/main/java/software/amazon/awssdk/protocols/query/internal/unmarshall/AwsXmlErrorUnmarshaller.java

@@ -69,7 +69,7 @@ private QueryProtocolUnmarshaller(Builder builder) {
 
     public <TypeT extends SdkPojo> Pair<TypeT, Map<String, String>> unmarshall(SdkPojo sdkPojo,
                                                                                SdkHttpFullResponse response) {
-        XmlElement document = response.content().map(XmlDomParser::parse).orElse(XmlElement.empty());
+        XmlElement document = response.content().map(XmlDomParser::parse).orElseGet(XmlElement::empty);
         XmlElement resultRoot = hasResultWrapper ? document.getFirstChild() : document;
         return Pair.of(unmarshall(sdkPojo, resultRoot, response), parseMetadata(document));
     }

core/protocols/aws-query-protocol/src/main/java/software/amazon/awssdk/protocols/query/internal/unmarshall/QueryProtocolUnmarshaller.java

@@ -75,7 +75,7 @@ private static Optional<String> getKeyStore() {
 
     private static String getKeyStoreType() {
         return SystemSettingUtils.resolveSetting(SSL_KEY_STORE_TYPE)
-                .orElse(KeyStore.getDefaultType());
+                .orElseGet(KeyStore::getDefaultType);
     }
 
     private static Optional<String> getKeyStorePassword() {

http-client-spi/src/main/java/software/amazon/awssdk/http/SystemPropertyTlsKeyManagersProvider.java

@@ -126,8 +126,9 @@ public static Builder builder() {
     private EventLoopGroup resolveEventLoopGroup(DefaultBuilder builder) {
         int numThreads = Optional.ofNullable(builder.numberOfThreads).orElse(0);
         ThreadFactory threadFactory = Optional.ofNullable(builder.threadFactory)
-                                              .orElse(new ThreadFactoryBuilder().threadNamePrefix("aws-java-sdk-NettyEventLoop")
-                                                                                .build());
+                                              .orElseGet(() -> new ThreadFactoryBuilder()
+                                                  .threadNamePrefix("aws-java-sdk-NettyEventLoop")
+                                                  .build());
         return new NioEventLoopGroup(numThreads, threadFactory);
         /*
         Need to investigate why epoll is raising channel inactive after successful response that causes

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/SdkEventLoopGroup.java

@@ -53,7 +53,7 @@ public Exception transformException(Exception crtRuntimeException) {
         Exception exception = crtS3RuntimeExceptionOptional
                 .filter(CrtErrorHandler::isErrorDetailsAvailable)
                 .map(e -> getServiceSideException(e))
-                .orElse(SdkClientException.create(crtRuntimeException.getMessage(), crtRuntimeException));
+                .orElseGet(() -> SdkClientException.create(crtRuntimeException.getMessage(), crtRuntimeException));
         return exception;
     }
 

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/CrtErrorHandler.java

@@ -77,19 +77,19 @@ public <T> T option(TransferConfigurationOption<T> option) {
     public boolean resolveUploadDirectoryRecursive(UploadDirectoryRequest request) {
         return request.overrideConfiguration()
                       .flatMap(UploadDirectoryOverrideConfiguration::recursive)
-                      .orElse(options.get(UPLOAD_DIRECTORY_RECURSIVE));
+                      .orElseGet(() -> options.get(UPLOAD_DIRECTORY_RECURSIVE));
     }
 
     public boolean resolveUploadDirectoryFollowSymbolicLinks(UploadDirectoryRequest request) {
         return request.overrideConfiguration()
                       .flatMap(UploadDirectoryOverrideConfiguration::followSymbolicLinks)
-                      .orElse(options.get(UPLOAD_DIRECTORY_FOLLOW_SYMBOLIC_LINKS));
+                      .orElseGet(() -> options.get(UPLOAD_DIRECTORY_FOLLOW_SYMBOLIC_LINKS));
     }
 
     public int resolveUploadDirectoryMaxDepth(UploadDirectoryRequest request) {
         return request.overrideConfiguration()
                       .flatMap(UploadDirectoryOverrideConfiguration::maxDepth)
-                      .orElse(options.get(UPLOAD_DIRECTORY_MAX_DEPTH));
+                      .orElseGet(() -> options.get(UPLOAD_DIRECTORY_MAX_DEPTH));
     }
 
     @Override

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/TransferManagerConfiguration.java

@@ -35,8 +35,8 @@ public class ChecksumCalculatingAsyncRequestBody implements AsyncRequestBody {
     public ChecksumCalculatingAsyncRequestBody(SdkHttpRequest request, AsyncRequestBody wrapped, SdkChecksum sdkChecksum) {
         this.contentLength = request.firstMatchingHeader("Content-Length")
                                     .map(Long::parseLong)
-                                    .orElse(wrapped.contentLength()
-                                                   .orElse(null));
+                                    .orElseGet(() -> wrapped.contentLength()
+                                                            .orElse(null));
         this.wrapped = wrapped;
         this.sdkChecksum = sdkChecksum;
     }