Skip to content

Commit 13c0f0c

Browse files
Bump assertj-core from 3.8.0 to 3.20.2 (#2546)
* Bump assertj-core from 3.8.0 to 3.20.2 Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.8.0 to 3.20.2. - [Release notes](https://github.com/assertj/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.8.0...assertj-core-3.20.2) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix test code AssertJ changed some APIs so make tests compliant with new APIs. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dongie Agnir <[email protected]> Co-authored-by: Dongie Agnir <[email protected]>
1 parent f0ae77e commit 13c0f0c

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkNumberTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ public void numberFromString() {
148148

149149
@Test
150150
public void numberFromNaNDouble() {
151-
final SdkNumber sdkNan = SdkNumber.fromDouble(Double.longBitsToDouble(0x7ff8000000000000L));
152-
final Double nanDouble = Double.longBitsToDouble(0x7ff8000000000000L);
151+
final SdkNumber sdkNan = SdkNumber.fromDouble(Double.NaN);
152+
final Double nanDouble = Double.NaN;
153153
assertThat(nanDouble.isNaN()).isTrue();
154154
assertThatThrownBy(() -> sdkNan.bigDecimalValue()).isInstanceOf(NumberFormatException.class);
155155
assertEqualitySDKNumberWithNumber(sdkNan, nanDouble);
@@ -207,7 +207,8 @@ private void assertEqualitySDKNumberWithNumber(SdkNumber sdkNan, Number nanDoubl
207207
assertThat(sdkNan.intValue()).isEqualTo(nanDouble.intValue());
208208
assertThat(sdkNan).hasToString(nanDouble.toString());
209209
assertThat(sdkNan.byteValue()).isEqualTo(nanDouble.byteValue());
210-
assertThat(sdkNan.doubleValue()).isEqualTo(nanDouble.doubleValue());
210+
// convert to nullable Double to prevent comparison of primitives because Double.NaN == Double.NaN is false
211+
assertThat(Double.valueOf(sdkNan.doubleValue())).isEqualTo(Double.valueOf(nanDouble.doubleValue()));
211212
assertThat(sdkNan.byteValue()).isEqualTo(nanDouble.byteValue());
212213
}
213214

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
<hamcrest.version>1.3</hamcrest.version>
122122
<mockito.version>1.10.19</mockito.version>
123123
<mockito2.version>2.28.2</mockito2.version>
124-
<assertj.version>3.8.0</assertj.version>
124+
<assertj.version>3.20.2</assertj.version>
125125
<guava.version>29.0-jre</guava.version>
126126
<jimfs.version>1.1</jimfs.version>
127127
<testng.version>7.1.0</testng.version> <!-- TCK Tests -->

services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/mocktests/BatchGetItemTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public void responseWithUnprocessedKeys_iteratePage_shouldFetchUnprocessedKeys()
114114

115115
BatchGetResultPage secondPage = iterator.next();
116116
assertThat(secondPage.resultsForTable(table).size()).isEqualTo(1);
117-
assertThat(iterator).isEmpty();
117+
assertThat(iterator).isExhausted();
118118
}
119119

120120
@Test

0 commit comments

Comments
 (0)