Minor updates to identity-spi (#3989)

* Made interfaces @SdkPublicApi
* Added test for equals and hashCode

Author: gosar

core/identity-spi/pom.xml

@@ -44,5 +44,32 @@
             <artifactId>utils</artifactId>
             <version>${awsjavasdk.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>nl.jqno.equalsverifier</groupId>
+            <artifactId>equalsverifier</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <configuration>
+                    <archive>
+                        <manifestEntries>
+                            <Automatic-Module-Name>software.amazon.awssdk.identity.spi</Automatic-Module-Name>
+                        </manifestEntries>
+                    </archive>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
 </project>

core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/IdentityProperty.java

@@ -17,7 +17,7 @@
 
 import java.util.Objects;
 import software.amazon.awssdk.annotations.Immutable;
-import software.amazon.awssdk.annotations.SdkProtectedApi;
+import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.annotations.ThreadSafe;
 import software.amazon.awssdk.utils.ToString;
 import software.amazon.awssdk.utils.Validate;
@@ -26,7 +26,7 @@
  * A strongly-typed property for input to an {@link IdentityProvider}.
  * @param <T> The type of the attribute.
  */
-@SdkProtectedApi
+@SdkPublicApi
 @Immutable
 @ThreadSafe
 public final class IdentityProperty<T> {

core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java

@@ -19,7 +19,7 @@
 import java.util.Map;
 import java.util.Objects;
 import software.amazon.awssdk.annotations.Immutable;
-import software.amazon.awssdk.annotations.SdkProtectedApi;
+import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.annotations.ThreadSafe;
 import software.amazon.awssdk.utils.ToString;
 import software.amazon.awssdk.utils.builder.SdkBuilder;
@@ -32,12 +32,12 @@
  *
  * @see IdentityProvider
  */
-@SdkProtectedApi
+@SdkPublicApi
 @Immutable
 @ThreadSafe
 public final class ResolveIdentityRequest {
 
-    private final Map<IdentityProperty<?>, ?> properties;
+    private final Map<IdentityProperty<?>, Object> properties;
 
     private ResolveIdentityRequest(Map<IdentityProperty<?>, Object> properties) {
         this.properties = new HashMap<>(properties);

core/identity-spi/src/test/java/software/amazon/awssdk/identity/spi/IdentityPropertyTest.java

@@ -0,0 +1,29 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package software.amazon.awssdk.identity.spi;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Test;
+
+public class IdentityPropertyTest {
+
+    @Test
+    public void equalsHashcode() {
+        EqualsVerifier.forClass(IdentityProperty.class)
+                      .withNonnullFields("clazz", "name")
+                      .verify();
+    }
+}