Adding GenerateAuthenticationTokenRequestTestClass and addressing nits

Author: pandhera

services/axdbfrontend/src/main/java/software/amazon/awssdk/services/axdbfrontend/model/Action.java

@@ -23,7 +23,13 @@
  */
 @SdkPublicApi
 public enum Action implements Serializable {
+    /**
+     * The action of connecting to an AxdbFrontend database using DbConnect
+     */
     DB_CONNECT("DbConnect"),
+    /**
+     * The action of connecting to an AxdbFrontend database using DbConnectSuperuser
+     */
     DB_CONNECT_SUPERUSER("DbConnectSuperuser");
 
     private final String action;
@@ -36,7 +42,7 @@ public String getAction() {
         return action;
     }
 
-    public static Action variant(String value) {
+    public static Action fromValue(String value) {
         for (Action action : Action.values()) {
             if (value.equalsIgnoreCase(action.name())) {
                 return action;

services/axdbfrontend/src/test/java/software/amazon/awssdk/services/axdbfrontend/DefaultAxdbFrontendUtilitiesTest.java

@@ -22,7 +22,6 @@
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
 import java.util.function.Consumer;
-import nl.jqno.equalsverifier.EqualsVerifier;
 import org.junit.jupiter.api.Test;
 import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
@@ -41,36 +40,30 @@ public class DefaultAxdbFrontendUtilitiesTest {
     private final Clock fixedClock = Clock.fixed(ZonedDateTime.of(2024, 11, 7, 17, 39, 33, 0, utcZone).toInstant(), utcZone);
 
     @Test
-    void equalsHashcode() {
-        EqualsVerifier.forClass(GenerateAuthenticationTokenRequest.class)
-                      .withNonnullFields("hostname", "region", "action", "expiresIn", "credentialsProvider")
-                      .verify();
-    }
-    @Test
-    public void testTokenGenerationWithBuilderDefaultsUsingAwsCredentialsProvider() {
+    public void tokenGenerationWithBuilderDefaultsUsingAwsCredentialsProvider_isSuccessful() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
         DefaultBuilder utilitiesBuilder = (DefaultBuilder) AxdbFrontendUtilities.builder()
                                                                        .credentialsProvider(credentialsProvider)
                                                                        .region(Region.US_EAST_1);
 
-        testTokenGenerationWithBuilderDefaults(utilitiesBuilder);
+        tokenGenerationWithBuilderDefaults(utilitiesBuilder);
     }
 
     @Test
-    public void testTokenGenerationWithBuilderDefaultsUsingIdentityProvider() {
+    public void tokenGenerationWithBuilderDefaultsUsingIdentityProvider_isSuccessful() {
         IdentityProvider<AwsCredentialsIdentity> credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
         DefaultBuilder utilitiesBuilder = (DefaultBuilder) AxdbFrontendUtilities.builder()
                                                                        .credentialsProvider(credentialsProvider)
                                                                        .region(Region.US_EAST_1);
 
-        testTokenGenerationWithBuilderDefaults(utilitiesBuilder);
+        tokenGenerationWithBuilderDefaults(utilitiesBuilder);
     }
 
-    private void testTokenGenerationWithBuilderDefaults(DefaultBuilder utilitiesBuilder) {
+    private void tokenGenerationWithBuilderDefaults(DefaultBuilder utilitiesBuilder) {
         DefaultAxdbFrontendUtilities AxdbFrontendUtilities = new DefaultAxdbFrontendUtilities(utilitiesBuilder, fixedClock);
         Action action = Action.DB_CONNECT_SUPERUSER;
 
@@ -88,34 +81,34 @@ private void testTokenGenerationWithBuilderDefaults(DefaultBuilder utilitiesBuil
     }
 
     @Test
-    public void testTokenGenerationWithOverriddenCredentialsUsingAwsCredentialsProvider() {
+    public void tokenGenerationWithOverriddenCredentialsUsingAwsCredentialsProvider_isSuccessful() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("foo", "bar")
         );
         DefaultBuilder utilitiesBuilder = (DefaultBuilder) AxdbFrontendUtilities.builder()
                                                                        .credentialsProvider(credentialsProvider)
                                                                        .region(Region.US_EAST_1);
-        testTokenGenerationWithOverriddenCredentials(utilitiesBuilder, builder -> {
+        tokenGenerationWithOverriddenCredentials(utilitiesBuilder, builder -> {
             builder.credentialsProvider(StaticCredentialsProvider.create(
                 AwsBasicCredentials.create("access_key", "secret_key")));
         });
     }
 
     @Test
-    public void testTokenGenerationWithOverriddenCredentialsUsingIdentityProvider() {
+    public void tokenGenerationWithOverriddenCredentialsUsingIdentityProvider_isSuccessful() {
         IdentityProvider<AwsCredentialsIdentity> credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("foo", "bar")
         );
         DefaultBuilder utilitiesBuilder = (DefaultBuilder) AxdbFrontendUtilities.builder()
                                                                        .credentialsProvider(credentialsProvider)
                                                                        .region(Region.US_EAST_1);
-        testTokenGenerationWithOverriddenCredentials(utilitiesBuilder, builder -> {
+        tokenGenerationWithOverriddenCredentials(utilitiesBuilder, builder -> {
             builder.credentialsProvider((IdentityProvider<AwsCredentialsIdentity>) StaticCredentialsProvider.create(
                 AwsBasicCredentials.create("access_key", "secret_key")));
         });
     }
 
-    private void testTokenGenerationWithOverriddenCredentials(DefaultBuilder utilitiesBuilder,
+    private void tokenGenerationWithOverriddenCredentials(DefaultBuilder utilitiesBuilder,
                                                               Consumer<GenerateAuthenticationTokenRequest.Builder> credsBuilder) {
         DefaultAxdbFrontendUtilities AxdbFrontendUtilities = new DefaultAxdbFrontendUtilities(utilitiesBuilder, fixedClock);
         Action action = Action.DB_CONNECT_SUPERUSER;
@@ -135,7 +128,7 @@ private void testTokenGenerationWithOverriddenCredentials(DefaultBuilder utiliti
     }
 
     @Test
-    public void testTokenGenerationWithOverriddenRegion() {
+    public void tokenGenerationWithOverriddenRegion_isSuccessful() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
@@ -161,7 +154,7 @@ public void testTokenGenerationWithOverriddenRegion() {
     }
 
     @Test
-    public void testMissingRegionThrowsException() {
+    public void missingRegion_throwsException() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
@@ -179,7 +172,7 @@ public void testMissingRegionThrowsException() {
     }
 
     @Test
-    public void testMissingCredentialsThrowsException() {
+    public void missingCredentials_throwsException() {
         DefaultBuilder utilitiesBuilder = (DefaultBuilder) AxdbFrontendUtilities.builder()
                                                                        .region(Region.US_WEST_2);
 
@@ -194,7 +187,7 @@ public void testMissingCredentialsThrowsException() {
     }
 
     @Test
-    public void testMissingHostnameThrowsException() {
+    public void missingHostname_throwsException() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
@@ -211,7 +204,7 @@ public void testMissingHostnameThrowsException() {
     }
 
     @Test
-    public void testMissingActionThrowsException() {
+    public void missingAction_throwsException() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );
@@ -228,7 +221,7 @@ public void testMissingActionThrowsException() {
     }
 
     @Test
-    public void testTokenGenerationWithCustomExpiry() {
+    public void tokenGenerationWithCustomExpiry_isSuccessful() {
         AwsCredentialsProvider credentialsProvider = StaticCredentialsProvider.create(
             AwsBasicCredentials.create("access_key", "secret_key")
         );

services/axdbfrontend/src/test/java/software/amazon/awssdk/services/axdbfrontend/GenerateAuthenticationTokenRequestTest.java

@@ -0,0 +1,28 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+package software.amazon.awssdk.services.axdbfrontend;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Test;
+import software.amazon.awssdk.services.axdbfrontend.model.GenerateAuthenticationTokenRequest;
+
+public class GenerateAuthenticationTokenRequestTest {
+    @Test
+    void equalsHashcode() {
+        EqualsVerifier.forClass(GenerateAuthenticationTokenRequest.class)
+                      .withNonnullFields("hostname", "region", "action")
+                      .verify();
+    }
+}