Skip to content

Commit 3416f89

Browse files
committed
Add a warning to note that checksumValidationEnabled is true by default.
1 parent 11abeb8 commit 3416f89

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/presigner/DefaultS3Presigner.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,20 @@
9090
import software.amazon.awssdk.services.s3.transform.PutObjectRequestMarshaller;
9191
import software.amazon.awssdk.services.s3.transform.UploadPartRequestMarshaller;
9292
import software.amazon.awssdk.utils.IoUtils;
93+
import software.amazon.awssdk.utils.Logger;
9394
import software.amazon.awssdk.utils.Validate;
9495

9596
/**
9697
* The default implementation of the {@link S3Presigner} interface.
9798
*/
9899
@SdkInternalApi
99100
public final class DefaultS3Presigner extends DefaultSdkPresigner implements S3Presigner {
101+
private static final Logger log = Logger.loggerFor(DefaultS3Presigner.class);
102+
100103
private static final AwsS3V4Signer DEFAULT_SIGNER = AwsS3V4Signer.create();
101104
private static final S3Configuration DEFAULT_S3_CONFIGURATION = S3Configuration.builder()
102-
.checksumValidationEnabled(false)
103-
.build();
105+
.checksumValidationEnabled(false)
106+
.build();
104107
private static final String SERVICE_NAME = "s3";
105108
private static final String SIGNING_NAME = "s3";
106109

@@ -117,6 +120,11 @@ private DefaultS3Presigner(Builder b) {
117120
super(b);
118121

119122
this.serviceConfiguration = b.serviceConfiguration != null ? b.serviceConfiguration : DEFAULT_S3_CONFIGURATION;
123+
if (serviceConfiguration.checksumValidationEnabled()) {
124+
log.debug(() -> "The provided S3Configuration has ChecksumValidationEnabled set to true. Please note that "
125+
+ "the pre-signed request can't be executed using a web browser if checksum validation is enabled.");
126+
}
127+
120128

121129
this.clientInterceptors = initializeInterceptors();
122130

0 commit comments

Comments
 (0)