Added Null checks and test cases

Author: joviegas

services/s3/src/main/java/software/amazon/awssdk/services/s3/S3CrtAsyncClientBuilder.java

@@ -195,7 +195,7 @@ default S3CrtAsyncClientBuilder httpConfiguration(Consumer<S3CrtHttpConfiguratio
      * @see #retryConfiguration(S3CrtRetryConfiguration)
      */
     default S3CrtAsyncClientBuilder retryConfiguration(Consumer<S3CrtRetryConfiguration.Builder> retryConfigurationBuilder) {
-        Validate.paramNotNull(retryConfigurationBuilder, "configurationBuilder");
+        Validate.paramNotNull(retryConfigurationBuilder, "retryConfigurationBuilder");
         return retryConfiguration(S3CrtRetryConfiguration.builder()
                                                          .applyMutation(retryConfigurationBuilder)
                                                          .build());

services/s3/src/main/java/software/amazon/awssdk/services/s3/crt/S3CrtRetryConfiguration.java

@@ -19,6 +19,7 @@
 import software.amazon.awssdk.annotations.Immutable;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.annotations.ThreadSafe;
+import software.amazon.awssdk.core.retry.RetryPolicy;
 import software.amazon.awssdk.services.s3.S3CrtAsyncClientBuilder;
 import software.amazon.awssdk.utils.Validate;
 import software.amazon.awssdk.utils.builder.CopyableBuilder;
@@ -37,7 +38,7 @@ public final class S3CrtRetryConfiguration implements ToCopyableBuilder<S3CrtRet
     private final Integer numRetries;
 
     private S3CrtRetryConfiguration(DefaultBuilder builder) {
-        Validate.isPositiveOrNull(builder.numRetries, "numRetries");
+        Validate.notNull(builder.numRetries, "numRetries");
         this.numRetries = builder.numRetries;
     }
 
@@ -49,7 +50,7 @@ public static Builder builder() {
     }
 
     /**
-     * Return the amount of time to wait when initially establishing a connection before giving up and timing out.
+     * Retrieve the {@link S3CrtRetryConfiguration.Builder#numRetries(Integer)} configured on the builder.
      */
     public Integer numRetries() {
         return numRetries;

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/DefaultS3CrtAsyncClient.java

@@ -105,9 +105,7 @@ private static S3CrtAsyncHttpClient.Builder initializeS3CrtAsyncHttpClient(Defau
                                        .targetThroughputInGbps(builder.targetThroughputInGbps)
                                        .partSizeInBytes(builder.minimalPartSizeInBytes)
                                        .maxConcurrency(builder.maxConcurrency)
-                                       .signingRegion(builder.region == null ? null
-                                                                             :
-                                                      builder.region.id())
+                                       .signingRegion(builder.region == null ? null : builder.region.id())
                                        .endpointOverride(builder.endpointOverride)
                                        .credentialsProvider(builder.credentialsProvider)
                                        .readBufferSizeInBytes(builder.readBufferSizeInBytes)

services/s3/src/test/java/software/amazon/awssdk/services/s3/crt/S3CrtRetryConfigurationTest.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package software.amazon.awssdk.services.s3.crt;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.assertj.core.api.Assertions.assertThatNullPointerException;
+
+
+public class S3CrtRetryConfigurationTest {
+
+    @Test
+    void equalsHashcode() {
+        EqualsVerifier.forClass(S3CrtRetryConfiguration.class)
+                      .withRedefinedSuperclass()
+                      .verify();
+    }
+
+    @Test
+    void retryConfigurationWithNoMaxRetriesDefined(){
+        assertThatNullPointerException().isThrownBy(() ->S3CrtRetryConfiguration.builder().build())
+            .withMessage("numRetries");
+    }
+
+
+
+}