Skip to content

Commit 3808e75

Browse files
committed
Spotbug issue fixed and using StringUtils
1 parent 84aca63 commit 3808e75

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static software.amazon.awssdk.enhanced.dynamodb.internal.document.JsonStringFormatHelper.addEscapeCharacters;
2121
import static software.amazon.awssdk.enhanced.dynamodb.internal.document.JsonStringFormatHelper.stringValue;
2222

23+
import com.amazonaws.util.StringUtils;
2324
import java.util.ArrayList;
2425
import java.util.Arrays;
2526
import java.util.HashMap;
@@ -190,11 +191,7 @@ public String getJson(String attributeName) {
190191

191192
@Override
192193
public Boolean getBoolean(String attributeName) {
193-
Boolean value = get(attributeName, Boolean.class);
194-
if (value == null) {
195-
return null;
196-
}
197-
return value.booleanValue();
194+
return get(attributeName, Boolean.class);
198195
}
199196

200197
@Override
@@ -402,8 +399,7 @@ public Builder putJson(String attributeName, String json) {
402399

403400
@Override
404401
public Builder remove(String attributeName) {
405-
Validate.isTrue(!(attributeName == null || attributeName.trim().length() == 0),
406-
"Attribute name must not be null or empty");
402+
Validate.isTrue(!StringUtils.isNullOrEmpty(attributeName), "Attribute name must not be null or empty");
407403
nonAttributeValueMap.remove(attributeName);
408404
return this;
409405
}

0 commit comments

Comments
 (0)