Cleanup TODO in ResponseHandler

varunnvs92 · varunnvs92 · commit 5ea93a980626 · 2018-09-21T12:52:04.000-07:00
diff --git a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/ResponseHandler.java b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/ResponseHandler.java
@@ -202,8 +202,6 @@ private Subscription resolveSubscription(Subscription subscription) {
                     if (Protocol.HTTP2.equals(ChannelAttributeKey.getProtocolNow(channelContext.channel()))) {
                         return new Http2ResetSendingSubscription(channelContext, subscription);
                     } else {
-                        // TODO I believe the behavior for H1 is to finish reading the data. Do we want to do this
-                        // or abort the connection?
                         return subscription;
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -202,8 +202,6 @@ private Subscription resolveSubscription(Subscription subscription) {`
`202`	`202`	`if (Protocol.HTTP2.equals(ChannelAttributeKey.getProtocolNow(channelContext.channel()))) {`
`203`	`203`	`return new Http2ResetSendingSubscription(channelContext, subscription);`
`204`	`204`	`} else {`
`205`		`- // TODO I believe the behavior for H1 is to finish reading the data. Do we want to do this`
`206`		`- // or abort the connection?`
`207`	`205`	`return subscription;`
`208`	`206`	`}`
`209`	`207`	`}`