Don't generate duplicate client context params (#2182)

For S3, the client context params are duplicated on on its ServiceConfiguration.
For these duplicates, just keep them in the ServiceConfiguration.

Author: dagnir

codegen/src/main/java/software/amazon/awssdk/codegen/poet/builder/BaseClientBuilderClass.java

@@ -110,7 +110,9 @@ public TypeSpec poetSpec() {
 
         if (hasClientContextParams()) {
             model.getClientContextParams().forEach((n, m) -> {
-                builder.addMethod(clientContextParamSetter(n, m));
+                if (endpointRulesSpecUtils.shouldGenerateClientContextParamSetter(n)) {
+                    builder.addMethod(clientContextParamSetter(n, m));
+                }
             });
         }
 
@@ -486,6 +488,7 @@ private MethodSpec clientContextParamSetter(String name, ClientContextParam para
 
         return MethodSpec.methodBuilder(setterName)
                          .addModifiers(Modifier.PUBLIC)
+                         .addAnnotation(Override.class)
                          .returns(TypeVariableName.get("B"))
                          .addParameter(type, setterName)
                          .addStatement("clientContextParams.put($T.$N, $N)", endpointRulesSpecUtils.clientContextParamsName(),

codegen/src/main/java/software/amazon/awssdk/codegen/poet/builder/BaseClientBuilderInterface.java

@@ -72,7 +72,9 @@ public TypeSpec poetSpec() {
 
         if (hasClientContextParams()) {
             model.getClientContextParams().forEach((n, m) -> {
-                builder.addMethod(clientContextParamSetter(n, m));
+                if (endpointRulesSpecUtils.shouldGenerateClientContextParamSetter(n)) {
+                    builder.addMethod(clientContextParamSetter(n, m));
+                }
             });
         }
 

codegen/src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointRulesSpecUtils.java

@@ -104,6 +104,26 @@ public String clientContextParamName(String paramName) {
         return intermediateModel.getNamingStrategy().getEnumValueName(paramName);
     }
 
+    /**
+     * S3 and S3 Control have ServiceConfiguration customizations that would duplicate some context params. Avoid
+     * the duplication by not generating the client context param setters on the client for those parameters.
+     */
+    public boolean shouldGenerateClientContextParamSetter(String paramName) {
+        if (!isS3()) {
+            return true;
+        }
+
+        switch (paramName) {
+            case "Accelerate":
+            case "DisableMultiRegionAccessPoints":
+            case "ForcePathStyle":
+            case "UseArnRegion":
+                return false;
+            default:
+                return true;
+        }
+    }
+
     public TypeName toJavaType(String type) {
         switch (type.toLowerCase(Locale.ENGLISH)) {
             case "boolean":
@@ -162,6 +182,11 @@ public CodeBlock treeNodeToLiteral(TreeNode treeNode) {
         return b.build();
     }
 
+
+    private boolean isS3() {
+        return "S3".equals(intermediateModel.getMetadata().getServiceName());
+    }
+
     private static JrsString asString(TreeNode node) {
         if (node instanceof JrsString) {
             return (JrsString) node;