Skip to content

Commit 68667cb

Browse files
committed
Preserve prefix when moving from new to builder
Previously, this SendMessageRequest sendMessage = new SendMessageRequest(); is getting transformed to this (o space after =) SendMessageRequest sendMessage =SendMessageRequest.builder().build();
1 parent a2e0bc5 commit 68667cb

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

migration-tool/src/main/java/software/amazon/awssdk/migration/internal/recipe/NewV1ClassToBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext executionContext) {
150150

151151
J.MethodInvocation buildInvoke = new J.MethodInvocation(
152152
Tree.randomId(),
153-
Space.EMPTY,
153+
newClass.getPrefix(),
154154
Markers.EMPTY,
155155
JRightPadded.build(builderInvoke),
156156
null,

migration-tool/src/test/java/software/amazon/awssdk/migration/recipe/NewV1ModelClassToV2Test.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,4 +150,29 @@ public void request_returnedFromMethod_isRewritten() {
150150
)
151151
);
152152
}
153+
154+
@Test
155+
@EnabledOnJre({JRE.JAVA_8})
156+
public void request_assignedToVariable_newOnly_isRewritten() {
157+
rewriteRun(
158+
java(
159+
"import com.amazonaws.services.sqs.AmazonSQS;\n"
160+
+ "import com.amazonaws.services.sqs.model.SendMessageRequest;\n"
161+
+ "\n"
162+
+ "public class SqsExample {\n"
163+
+ " public static void main(String[] args) {\n"
164+
+ " SendMessageRequest sendMessage = new SendMessageRequest();\n"
165+
+ " }\n"
166+
+ "}\n",
167+
"import com.amazonaws.services.sqs.AmazonSQS;\n"
168+
+ "import com.amazonaws.services.sqs.model.SendMessageRequest;\n"
169+
+ "\n"
170+
+ "public class SqsExample {\n"
171+
+ " public static void main(String[] args) {\n"
172+
+ " SendMessageRequest sendMessage = SendMessageRequest.builder().build();\n"
173+
+ " }\n"
174+
+ "}"
175+
)
176+
);
177+
}
153178
}

0 commit comments

Comments
 (0)