Skip to content

Commit 832c1b9

Browse files
authored
Merge pull request #3268 from aws/hdavidh/fix-integ-tests-user-agent-assertion
Update assertions for user agent in S3 integ tests
2 parents 6618fde + 40aadb2 commit 832c1b9

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

http-clients/url-connection-client/src/it/java/software/amazon/awssdk/http/urlconnection/S3WithUrlHttpClientIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ private static final class UserAgentVerifyingInterceptor implements ExecutionInt
147147

148148
@Override
149149
public void beforeTransmission(Context.BeforeTransmission context, ExecutionAttributes executionAttributes) {
150-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io/sync");
151-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http/UrlConnection");
150+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io#sync");
151+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http#UrlConnection");
152152
}
153153
}
154154

services/s3/src/it/java/software/amazon/awssdk/services/s3/S3IntegrationTestBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ public UserAgentVerifyingExecutionInterceptor(String clientName, ClientType clie
147147

148148
@Override
149149
public void beforeTransmission(Context.BeforeTransmission context, ExecutionAttributes executionAttributes) {
150-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io/" + clientType.name());
151-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http/" + clientName);
150+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io#" + clientType.name());
151+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http#" + clientName);
152152
}
153153
}
154154
}

services/s3control/src/it/java/software.amazon.awssdk.services.s3control/S3ControlIntegrationTestBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ public UserAgentVerifyingExecutionInterceptor(String clientName, ClientType clie
143143

144144
@Override
145145
public void beforeTransmission(Context.BeforeTransmission context, ExecutionAttributes executionAttributes) {
146-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io/" + clientType.name());
147-
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http/" + clientName);
146+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("io#" + clientType.name());
147+
assertThat(context.httpRequest().firstMatchingHeader("User-Agent").get()).containsIgnoringCase("http#" + clientName);
148148
}
149149
}
150150

0 commit comments

Comments
 (0)