Skip to content

Commit 84d63fc

Browse files
committed
Address PR comments
1 parent bd01aaa commit 84d63fc

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

core/aws-core/src/main/java/software/amazon/awssdk/awscore/client/builder/AwsDefaultClientBuilder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,8 @@ private SdkClientConfiguration finalizeAwsConfiguration(SdkClientConfiguration c
192192
/**
193193
* Apply the client override configuration to the provided configuration.
194194
*/
195-
protected SdkClientConfiguration setOverrides(SdkClientConfiguration configuration) {
195+
@Override
196+
protected final SdkClientConfiguration setOverrides(SdkClientConfiguration configuration) {
196197
if (overrideConfig == null) {
197198
return configuration;
198199
}

core/sdk-core/src/main/java/software/amazon/awssdk/core/client/config/ClientOverrideConfiguration.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -484,18 +484,20 @@ default Builder retryPolicy(RetryMode retryMode) {
484484

485485
RetryPolicy retryPolicy();
486486

487+
/**
488+
* Configure the retry strategy that should be used when handling failure cases.
489+
*/
490+
Builder retryStrategy(RetryStrategy retryStrategy);
491+
487492
/**
488493
* Configure the retry mode used to resolve the corresponding {@link RetryStrategy} that should be used when handling
489494
* failure cases.
490495
*
491496
* @see RetryMode
492497
*/
493-
Builder retryStrategy(RetryMode retryMode);
494-
495-
/**
496-
* Configure the retry strategy that should be used when handling failure cases.
497-
*/
498-
Builder retryStrategy(RetryStrategy retryStrategy);
498+
default Builder retryStrategy(RetryMode retryMode) {
499+
throw new UnsupportedOperationException();
500+
}
499501

500502
/**
501503
* Configure a consumer to customize the default retry strategy. The default retry strategy is obtained by using the
@@ -510,7 +512,9 @@ default Builder retryPolicy(RetryMode retryMode) {
510512
* <p>
511513
* Defaults to {@link RetryMode#LEGACY} if no configuration setting is found.
512514
*/
513-
Builder retryStrategy(Consumer<RetryStrategy.Builder<?, ?>> configurator);
515+
default Builder retryStrategy(Consumer<RetryStrategy.Builder<?, ?>> configurator) {
516+
throw new UnsupportedOperationException();
517+
}
514518

515519
RetryStrategy retryStrategy();
516520

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@
645645
<includeModule>profiles</includeModule>
646646
<includeModule>protocols</includeModule>
647647
<includeModule>regions</includeModule>
648-
<!-- <includeModule>sdk-core</includeModule> -->
648+
<includeModule>sdk-core</includeModule>
649649
<includeModule>http-client-spi</includeModule>
650650
<includeModule>apache-client</includeModule>
651651
<includeModule>netty-nio-client</includeModule>

0 commit comments

Comments
 (0)