Fix V1GetterToV2 to not change get method (#5338)

Author: zoewangg

migration-tool/src/main/java/software/amazon/awssdk/migration/internal/utils/NamingUtils.java

@@ -59,6 +59,6 @@ public static boolean isSetter(String name) {
     }
 
     public static boolean isGetter(String name) {
-        return !StringUtils.isBlank(name) && name.startsWith("get");
+        return !StringUtils.isBlank(name) && name.startsWith("get") && !name.equals("get");
     }
 }

migration-tool/src/test/java/software/amazon/awssdk/migration/internal/utils/NamingUtilsTest.java

@@ -91,4 +91,20 @@ public void removeSet_empty_returnsValue() {
     public void removeWith_empty_returnsValue() {
         assertThat(NamingUtils.removeWith("")).isEqualTo("");
     }
+
+    @Test
+    public void isGetter_startsWithGetter_returnsTrue() {
+        assertThat(NamingUtils.isGetter("getFoo")).isTrue();
+    }
+
+    @Test
+    public void isGetter_equalsToGet_returnsFalse() {
+        assertThat(NamingUtils.isGetter("get")).isFalse();
+    }
+
+    @Test
+    public void isGetter_emptyOrNull_returnsFalse() {
+        assertThat(NamingUtils.isGetter("")).isFalse();
+        assertThat(NamingUtils.isGetter(null)).isFalse();
+    }
 }

migration-tool/src/test/java/software/amazon/awssdk/migration/recipe/V1GetterToV2Test.java

@@ -37,6 +37,7 @@ void v1ModelClassGetter_isRewrittenToFluent() {
                 + "        ReceiveMessageRequest request = new ReceiveMessageRequest().withQueueUrl(\"url\");\n"
                 + "        ReceiveMessageResult receiveMessage = sqs.receiveMessage(request);\n"
                 + "        List<Message> messages = receiveMessage.getMessages();\n"
+                + "        Message message = receiveMessage.getMessages().get(0);\n"
                 + "    }\n"
                 + "}\n",
                 "import software.amazon.awssdk.services.sqs.SqsClient;\n"
@@ -50,6 +51,7 @@ void v1ModelClassGetter_isRewrittenToFluent() {
                 + "        ReceiveMessageRequest request = ReceiveMessageRequest.builder().queueUrl(\"url\").build();\n"
                 + "        ReceiveMessageResponse receiveMessage = sqs.receiveMessage(request);\n"
                 + "        List<Message> messages = receiveMessage.messages();\n"
+                + "        Message message = receiveMessage.messages().get(0);\n"
                 + "    }\n"
                 + "}"
             )

test/migration-tool-tests/src/test/resources/after/src/main/java/foo/bar/Application.java

@@ -48,15 +48,21 @@ public static void main(String... args) {
             .nextToken("token").build();
 
         try {
+
             ListQueuesResponse listQueuesResult = sqs.listQueues(request);
+            String queueUrl = listQueuesResult.queueUrls().get(0);
             String token = listQueuesResult.nextToken();
-            System.out.println(listQueuesResult);
+            System.out.println(queueUrl);
+            System.out.println(token);
+
         } catch (QueueDoesNotExistException exception) {
+
             String errorCode = exception.awsErrorDetails().errorCode();
             String errorMessage = exception.awsErrorDetails().errorMessage();
             String requestId = exception.requestId();
             byte[] rawResponse = exception.awsErrorDetails().rawResponse().asByteArray();
             System.out.println(String.format("Error code: %s, message: %s, requestId: %s", errorCode, errorMessage, requestId));
+
         } catch (SqsException exception) {
             System.out.println(String.format("Error code: %s. RequestId: %s. Raw response content: %s",
                                              exception.awsErrorDetails().errorCode(), exception.requestId(),

test/migration-tool-tests/src/test/resources/before/src/main/java/foo/bar/Application.java

@@ -46,15 +46,21 @@ public static void main(String... args) {
             .withNextToken("token");
 
         try {
+
             ListQueuesResult listQueuesResult = sqs.listQueues(request);
+            String queueUrl = listQueuesResult.getQueueUrls().get(0);
             String token = listQueuesResult.getNextToken();
-            System.out.println(listQueuesResult);
+            System.out.println(queueUrl);
+            System.out.println(token);
+
         } catch (QueueDoesNotExistException exception) {
+
             String errorCode = exception.getErrorCode();
             String errorMessage = exception.getErrorMessage();
             String requestId = exception.getRequestId();
             byte[] rawResponse = exception.getRawResponse();
             System.out.println(String.format("Error code: %s, message: %s, requestId: %s", errorCode, errorMessage, requestId));
+
         } catch (AmazonSQSException exception) {
             System.out.println(String.format("Error code: %s. RequestId: %s. Raw response content: %s",
                                              exception.getErrorCode(), exception.getRequestId(),