rebased and added CRT in Integ test

Author: joviegas

services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrtCrossRegionIntegrationTest.java renamed to services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrossRegionAsyncIntegrationTest.java

@@ -22,8 +22,8 @@
 import org.junit.jupiter.api.BeforeEach;
 import software.amazon.awssdk.services.s3.S3AsyncClient;
 
-public class S3CrtCrossRegionIntegrationTest extends S3AsyncCrossRegionIntegrationTestBase {
-    private static final String BUCKET = temporaryBucketName(S3CrtCrossRegionIntegrationTest.class);
+public class S3CrossRegionAsyncIntegrationTest extends S3CrossRegionAsyncIntegrationTestBase {
+    private static final String BUCKET = temporaryBucketName(S3CrossRegionAsyncIntegrationTest.class);
 
     @BeforeAll
     static void setUpClass() {
@@ -38,12 +38,12 @@ static void clearClass() {
 
     @BeforeEach
     public void initialize() {
-        // TODO : Update this with crtBuilder ones CRT related PR is merged
         crossRegionS3Client = S3AsyncClient.builder()
                                            .region(CROSS_REGION)
                                            .serviceConfiguration(s -> s.crossRegionAccessEnabled(true))
                                            .build();
     }
+
     @Override
     protected String bucketName() {
         return BUCKET;

services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3AsyncCrossRegionIntegrationTestBase.java renamed to services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrossRegionAsyncIntegrationTestBase.java

@@ -36,7 +36,7 @@
 import software.amazon.awssdk.services.s3.model.S3Object;
 import software.amazon.awssdk.services.s3.paginators.ListObjectsV2Publisher;
 
-public abstract class S3AsyncCrossRegionIntegrationTestBase extends S3CrossRegionIntegrationTestBase{
+public abstract class S3CrossRegionAsyncIntegrationTestBase extends S3CrossRegionIntegrationTestBase{
     protected S3AsyncClient crossRegionS3Client;
 
     @Override

services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3AsyncCrossRegionIntegrationTest.java renamed to services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrossRegionCrtIntegrationTest.java

@@ -22,8 +22,8 @@
 import org.junit.jupiter.api.BeforeEach;
 import software.amazon.awssdk.services.s3.S3AsyncClient;
 
-public class S3AsyncCrossRegionIntegrationTest extends S3AsyncCrossRegionIntegrationTestBase {
-    private static final String BUCKET = temporaryBucketName(S3AsyncCrossRegionIntegrationTest.class);
+public class S3CrossRegionCrtIntegrationTest extends S3CrossRegionAsyncIntegrationTestBase {
+    private static final String BUCKET = temporaryBucketName(S3CrossRegionCrtIntegrationTest.class);
 
     @BeforeAll
     static void setUpClass() {
@@ -38,12 +38,11 @@ static void clearClass() {
 
     @BeforeEach
     public void initialize() {
-        crossRegionS3Client = S3AsyncClient.builder()
+        crossRegionS3Client = S3AsyncClient.crtBuilder()
                                            .region(CROSS_REGION)
-                                           .serviceConfiguration(s -> s.crossRegionAccessEnabled(true))
+                                           .crossRegionAccessEnabled(true)
                                            .build();
     }
-
     @Override
     protected String bucketName() {
         return BUCKET;

services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrossRegionIntegrationTestBase.java

@@ -73,7 +73,6 @@ void deleteApi_CrossRegionCall() {
             "TEST_STRING"));
         DeleteObjectRequest deleteObjectRequest = DeleteObjectRequest.builder().bucket(bucketName()).key(KEY).build();
         DeleteObjectResponse response = deleteObjectAPICall(deleteObjectRequest);
-        System.out.println(response);
         assertThat(response).isNotNull();
     }
 
@@ -87,7 +86,6 @@ void postApi_CrossRegionCall() {
             DeleteObjectsRequest.builder().bucket(bucketName()).delete(d -> d.objects(o -> o.key(KEY), o -> o.key(KEY + "_1"))).build();
         DeleteObjectsResponse response = postObjectAPICall(deleteObjectsRequest);
         assertThat(response).isNotNull();
-        System.out.println(response);
     }
 
     @Test
@@ -124,7 +122,6 @@ void headApi_CrossRegionCall() {
         HeadBucketRequest headBucketRequest = HeadBucketRequest.builder().bucket(bucketName()).build();
         HeadBucketResponse response = headAPICall(headBucketRequest);
         assertThat(response).isNotNull();
-        System.out.println(response);
     }
 
     protected abstract List<S3Object> paginatedAPICall(ListObjectsV2Request listObjectsV2Request);

services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3SyncCrossRegionIntegrationTest.java renamed to services/s3/src/it/java/software/amazon/awssdk/services/s3/crossregion/S3CrossRegionSyncIntegrationTest.java

@@ -41,8 +41,8 @@
 import software.amazon.awssdk.services.s3.model.PutObjectResponse;
 import software.amazon.awssdk.services.s3.model.S3Object;
 
-public class S3SyncCrossRegionIntegrationTest extends S3CrossRegionIntegrationTestBase {
-    private static final String BUCKET = temporaryBucketName(S3SyncCrossRegionIntegrationTest.class);
+public class S3CrossRegionSyncIntegrationTest extends S3CrossRegionIntegrationTestBase {
+    private static final String BUCKET = temporaryBucketName(S3CrossRegionSyncIntegrationTest.class);
     private S3Client crossRegionS3Client;
 
     @BeforeAll

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClient.java

@@ -49,7 +49,6 @@
 import software.amazon.awssdk.utils.AttributeMap;
 import software.amazon.awssdk.utils.Logger;
 import software.amazon.awssdk.utils.NumericUtils;
-import software.amazon.awssdk.utils.StringUtils;
 import software.amazon.awssdk.utils.http.SdkHttpUtils;
 
 /**