Skip to content

Commit af35ead

Browse files
committed
Update to not generate upgrade-sdk-dependencies and change-enum-getters
1 parent 374644e commit af35ead

File tree

6 files changed

+441
-420
lines changed

6 files changed

+441
-420
lines changed

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/GradleProjectTest.java

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,21 @@
1717

1818
import static java.util.Collections.addAll;
1919
import static software.amazon.awssdk.v2migrationtests.TestUtils.assertTwoDirectoriesHaveSameStructure;
20+
import static software.amazon.awssdk.v2migrationtests.TestUtils.getMigrationToolVersion;
2021
import static software.amazon.awssdk.v2migrationtests.TestUtils.getVersion;
2122
import static software.amazon.awssdk.v2migrationtests.TestUtils.replaceVersion;
2223
import static software.amazon.awssdk.v2migrationtests.TestUtils.run;
2324

2425
import java.io.File;
2526
import java.io.IOException;
27+
import java.nio.file.Files;
2628
import java.nio.file.Path;
29+
import java.nio.file.attribute.PosixFilePermission;
2730
import java.util.ArrayList;
31+
import java.util.Arrays;
32+
import java.util.HashSet;
2833
import java.util.List;
34+
import java.util.Set;
2935
import org.apache.commons.io.FileUtils;
3036
import org.junit.jupiter.api.BeforeAll;
3137
import org.junit.jupiter.api.Test;
@@ -55,7 +61,19 @@ static void setUp() throws IOException {
5561
FileUtils.copyDirectory(gradleBefore.toFile(), gradleActual.toFile());
5662
FileUtils.copyDirectory(gradleAfter.toFile(), gradleExpected.toFile());
5763

58-
replaceVersion(gradleActual.resolve("init.gradle"), sdkVersion + "-PREVIEW");
64+
Path gradlew = gradleActual.resolve("gradlew");
65+
66+
Set<PosixFilePermission> perms = new HashSet<>();
67+
perms.addAll(Arrays.asList(PosixFilePermission.OWNER_READ,
68+
PosixFilePermission.OWNER_EXECUTE,
69+
PosixFilePermission.GROUP_EXECUTE,
70+
PosixFilePermission.GROUP_READ,
71+
PosixFilePermission.OTHERS_READ,
72+
PosixFilePermission.OTHERS_EXECUTE));
73+
74+
Files.setPosixFilePermissions(gradlew, perms);
75+
76+
replaceVersion(gradleActual.resolve("init.gradle"), getMigrationToolVersion() + "-PREVIEW");
5977
}
6078

6179
private static void deleteTempDirectories() throws IOException {

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/MavenProjectTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import static java.util.Collections.addAll;
1919
import static software.amazon.awssdk.v2migrationtests.TestUtils.assertTwoDirectoriesHaveSameStructure;
20+
import static software.amazon.awssdk.v2migrationtests.TestUtils.getMigrationToolVersion;
2021
import static software.amazon.awssdk.v2migrationtests.TestUtils.getVersion;
2122
import static software.amazon.awssdk.v2migrationtests.TestUtils.replaceVersion;
2223
import static software.amazon.awssdk.v2migrationtests.TestUtils.run;
@@ -73,7 +74,7 @@ void mavenProject_shouldConvert() throws IOException {
7374
private static void verifyTransformation() throws IOException {
7475
List<String> rewriteArgs = new ArrayList<>();
7576
addAll(rewriteArgs, "mvn", "org.openrewrite.maven:rewrite-maven-plugin:run",
76-
"-Drewrite.recipeArtifactCoordinates=software.amazon.awssdk:v2-migration:"+ sdkVersion + "-PREVIEW",
77+
"-Drewrite.recipeArtifactCoordinates=software.amazon.awssdk:v2-migration:"+ getMigrationToolVersion() + "-PREVIEW",
7778
"-Drewrite.activeRecipes=software.amazon.awssdk.v2migration.AwsSdkJavaV1ToV2");
7879

7980
run(mavenActual, rewriteArgs.toArray(new String[0]));

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/TestUtils.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,24 @@ public static void assertTwoDirectoriesHaveSameStructure(Path a, Path b) {
4242
}
4343

4444
public static String getVersion() throws IOException {
45+
// TODO: uncomment the following code to dynamically get version
46+
// once we update the version
47+
// Path root = Paths.get(".").normalize().toAbsolutePath();
48+
// Path pomFile = root.resolve("pom.xml");
49+
// Optional<String> versionString =
50+
// Files.readAllLines(pomFile)
51+
// .stream().filter(l -> l.contains("<version>")).findFirst();
52+
//
53+
// if (!versionString.isPresent()) {
54+
// throw new AssertionError("No version is found");
55+
// }
56+
//
57+
// String string = versionString.get().trim();
58+
// String substring = string.substring(9, string.indexOf('/') - 1);
59+
return "2.27.0";
60+
}
61+
62+
public static String getMigrationToolVersion() throws IOException {
4563
Path root = Paths.get(".").normalize().toAbsolutePath();
4664
Path pomFile = root.resolve("pom.xml");
4765
Optional<String> versionString =

v2-migration/pom.xml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -221,24 +221,6 @@
221221
<ignoreNonCompile>false</ignoreNonCompile>
222222
</configuration>
223223
</plugin>
224-
<plugin>
225-
<artifactId>exec-maven-plugin</artifactId>
226-
<groupId>org.codehaus.mojo</groupId>
227-
<version>${exec-maven-plugin.version}</version>
228-
<executions>
229-
<execution>
230-
<id>generate-recipe</id>
231-
<phase>generate-resources</phase>
232-
<goals>
233-
<goal>exec</goal>
234-
</goals>
235-
<configuration>
236-
<executable>python</executable>
237-
<commandlineArgs>${basedir}/src/main/resources/generate-recipes</commandlineArgs>
238-
</configuration>
239-
</execution>
240-
</executions>
241-
</plugin>
242224
<plugin>
243225
<groupId>org.apache.maven.plugins</groupId>
244226
<artifactId>maven-jar-plugin</artifactId>

0 commit comments

Comments
 (0)