Address feedback

Author: zoewangg

core/crt-core/pom.xml

@@ -25,6 +25,10 @@
     </parent>
 
     <artifactId>crt-core</artifactId>
+    <name>AWS Java SDK :: AWS CRT Core</name>
+    <description>The AWS SDK for Java - AWS CRT Core holds common types that are built on the AWS Common Runtime
+    </description>
+    <url>https://aws.amazon.com/sdkforjava</url>
     <dependencies>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClient.java

@@ -23,6 +23,7 @@
 import static software.amazon.awssdk.utils.FunctionalUtils.invokeSafely;
 
 import java.net.URI;
+import java.time.Duration;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
@@ -79,8 +80,9 @@ private S3CrtAsyncHttpClient(Builder builder) {
 
         Optional.ofNullable(s3NativeClientConfiguration.proxyOptions()).ifPresent(s3ClientOptions::withProxyOptions);
         Optional.ofNullable(s3NativeClientConfiguration.connectionTimeout())
-                .ifPresent(connectTimeoutMs -> s3ClientOptions.withConnectTimeoutMs(
-                    NumericUtils.saturatedCast(connectTimeoutMs.toMillis())));
+                .map(Duration::toMillis)
+                .map(NumericUtils::saturatedCast)
+                .ifPresent(s3ClientOptions::withConnectTimeoutMs);
         Optional.ofNullable(s3NativeClientConfiguration.httpMonitoringOptions())
                 .ifPresent(s3ClientOptions::withHttpMonitoringOptions);
 

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3NativeClientConfiguration.java

@@ -89,8 +89,7 @@ public S3NativeClientConfiguration(Builder builder) {
 
         if (builder.httpConfiguration != null) {
             this.proxyOptions = resolveProxy(builder.httpConfiguration.proxyConfiguration(), tlsContext).orElse(null);
-            this.connectionTimeout = builder.httpConfiguration.connectionTimeout() == null ? null :
-                                     builder.httpConfiguration.connectionTimeout();
+            this.connectionTimeout = builder.httpConfiguration.connectionTimeout();
             this.httpMonitoringOptions =
                 resolveHttpMonitoringOptions(builder.httpConfiguration.healthConfiguration()).orElse(null);
         } else {