Skip to content

Commit c6a8207

Browse files
committed
Use TestBase resources for signer integ tests
1 parent 3699f66 commit c6a8207

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

services/dynamodb/src/it/java/software/amazon/awssdk/services/dynamodb/SignersIntegrationTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import software.amazon.awssdk.http.SdkHttpMethod;
4040
import software.amazon.awssdk.http.SdkRequestContext;
4141
import software.amazon.awssdk.http.apache.ApacheHttpClient;
42-
import software.amazon.awssdk.regions.Region;
4342
import software.amazon.awssdk.services.dynamodb.model.AttributeDefinition;
4443
import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
4544
import software.amazon.awssdk.services.dynamodb.model.CreateTableRequest;
@@ -50,27 +49,24 @@
5049
import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput;
5150
import software.amazon.awssdk.services.dynamodb.model.PutItemRequest;
5251
import software.amazon.awssdk.services.dynamodb.model.ScalarAttributeType;
53-
import software.amazon.awssdk.testutils.service.AwsTestBase;
5452
import software.amazon.awssdk.utils.IoUtils;
5553
import utils.resources.tables.BasicTempTable;
54+
import utils.test.util.DynamoDBTestBase;
5655
import utils.test.util.TableUtils;
5756

58-
public class SignersIntegrationTest extends AwsTestBase {
57+
public class SignersIntegrationTest extends DynamoDBTestBase {
5958

60-
private static final Region REGION = Region.US_WEST_1;
6159
private static final String TABLE_NAME = BasicTempTable.TEMP_TABLE_NAME;
62-
private static final String HASH_KEY_NAME = "UID";
60+
private static final String HASH_KEY_NAME = BasicTempTable.HASH_KEY_NAME;
6361
private static final String HASH_KEY_VALUE = "123789";
6462
private static final String ATTRIBUTE_FOO = "foo";
6563
private static final String ATTRIBUTE_FOO_VALUE = "bar";
6664
private static final AwsCredentials awsCredentials = CREDENTIALS_PROVIDER_CHAIN.getCredentials();
6765
private static final String SIGNING_NAME = "dynamodb";
6866

69-
private static DynamoDBClient dynamo;
70-
7167
@BeforeClass
7268
public static void setUpFixture() throws Exception {
73-
dynamo = DynamoDBClient.builder().region(REGION).build();
69+
DynamoDBTestBase.setUpTestBase();
7470

7571
dynamo.createTable(CreateTableRequest.builder().tableName(TABLE_NAME)
7672
.keySchema(KeySchemaElement.builder().keyType(KeyType.HASH)
@@ -172,10 +168,14 @@ private SdkHttpFullRequest generateBasicRequest() {
172168
.header("X-Amz-Target", "DynamoDB_20120810.GetItem")
173169
.encodedPath("/")
174170
.protocol("https")
175-
.host("dynamodb.us-west-1.amazonaws.com")
171+
.host(getHost())
176172
.build();
177173
}
178174

175+
private String getHost() {
176+
return String.format("dynamodb.%s.amazonaws.com", REGION.value());
177+
}
178+
179179
private String getInputContent() {
180180
return "{ \n"
181181
+ " \"TableName\":\"" + TABLE_NAME + "\",\n"

services/dynamodb/src/test/java/utils/test/util/DynamoDBTestBase.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
public class DynamoDBTestBase extends AwsTestBase {
3939
protected static final String ENDPOINT = "http://dynamodb.us-east-1.amazonaws.com/";
4040

41+
protected static final Region REGION = Region.US_EAST_1;
42+
4143
protected static DynamoDBClient dynamo;
4244

4345
private static final Logger log = Logger.loggerFor(DynamoDBTestBase.class);
@@ -49,7 +51,7 @@ public static void setUpTestBase() {
4951
throw new SdkClientException("Unable to load credential property file.", e);
5052
}
5153

52-
dynamo = DynamoDBClient.builder().region(Region.US_EAST_1).credentialsProvider(CREDENTIALS_PROVIDER_CHAIN).build();
54+
dynamo = DynamoDBClient.builder().region(REGION).credentialsProvider(CREDENTIALS_PROVIDER_CHAIN).build();
5355
}
5456

5557
public static DynamoDBClient getClient() {

services/s3/src/it/java/software/amazon/awssdk/services/s3/signer/AwsS3V4SignerIntegrationTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.junit.Test;
3333
import software.amazon.awssdk.auth.AwsExecutionAttributes;
3434
import software.amazon.awssdk.auth.credentials.AwsCredentials;
35-
import software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider;
3635
import software.amazon.awssdk.auth.signer.Aws4Signer;
3736
import software.amazon.awssdk.auth.signer.params.Aws4PresignerParams;
3837
import software.amazon.awssdk.auth.signer.params.AwsS3V4SignerParams;
@@ -55,15 +54,13 @@
5554

5655
public class AwsS3V4SignerIntegrationTest extends S3IntegrationTestBase {
5756

57+
private static final AwsCredentials awsCredentials = CREDENTIALS_PROVIDER_CHAIN.getCredentials();
5858
private static final Region REGION = Region.US_WEST_2;
5959
private static final String SIGNING_NAME = "s3";
6060
private static final String BUCKET_NAME = temporaryBucketName("s3-signer-integ-test");
6161
private static final String KEY = "test-key";
6262
private static final String CONTENT = "Hello world";
6363

64-
private static final AwsCredentials awsCredentials = DefaultCredentialsProvider.create().getCredentials();
65-
private static final S3Client s3 = S3Client.builder().region(REGION).build();
66-
6764
@BeforeClass
6865
public static void setup() {
6966
createBucket(BUCKET_NAME);

0 commit comments

Comments
 (0)