Signer Refactor

Author: varunnvs92

auth/src/main/java/software/amazon/awssdk/auth/AwsExecutionAttributes.java

@@ -15,12 +15,13 @@
 
 package software.amazon.awssdk.auth;
 
+import java.util.Date;
 import software.amazon.awssdk.annotations.ReviewBeforeRelease;
 import software.amazon.awssdk.auth.credentials.AwsCredentials;
 import software.amazon.awssdk.core.interceptor.ExecutionAttribute;
 import software.amazon.awssdk.core.interceptor.ExecutionInterceptor;
 import software.amazon.awssdk.core.interceptor.SdkExecutionAttributes;
-import software.amazon.awssdk.core.runtime.auth.Signer;
+import software.amazon.awssdk.core.signer.Signer;
 import software.amazon.awssdk.regions.Region;
 
 /**
@@ -36,10 +37,33 @@ public final class AwsExecutionAttributes extends SdkExecutionAttributes {
     public static final ExecutionAttribute<AwsCredentials> AWS_CREDENTIALS = new ExecutionAttribute<>("AwsCredentials");
 
     /**
-     * The AWS {@link Region} the client was configured with.
+     * The AWS {@link Region} the client was configured with. This is not always same as {@link #SIGNING_REGION} for
+     * global services like IAM.
      */
     public static final ExecutionAttribute<Region> AWS_REGION = new ExecutionAttribute<>("AwsRegion");
 
+    /**
+     * The AWS {@link Region} that is used for signing a request. This is not always same as {@link #AWS_REGION} for
+     * global services like IAM.
+     */
+    public static final ExecutionAttribute<Region> SIGNING_REGION = new ExecutionAttribute<>("SigningRegion");
+
+    /**
+     * The signing name of the service to be using in SigV4 signing
+     */
+    public static final ExecutionAttribute<String> SERVICE_SIGNING_NAME = new ExecutionAttribute<>("ServiceSigningName");
+
+    /**
+     * The key to specify whether to use double url encoding during signing.
+     */
+    public static final ExecutionAttribute<Boolean> SIGNER_DOUBLE_URL_ENCODE = new ExecutionAttribute<>("DoubleUrlEncode");
+
+    /**
+     * The key to specify the expiration date when pre-signing aws requests.
+     */
+    public static final ExecutionAttribute<Date> AWS_PRESIGNER_EXPIRATION_DATE =
+        new ExecutionAttribute<>("PresignerExpirationDate");
+
     private AwsExecutionAttributes() {
     }
 }

auth/src/main/java/software/amazon/awssdk/auth/credentials/CanHandleNullCredentials.java

@@ -33,11 +33,10 @@
 import software.amazon.awssdk.annotations.ReviewBeforeRelease;
 import software.amazon.awssdk.auth.credentials.AwsCredentials;
 import software.amazon.awssdk.auth.credentials.AwsSessionCredentials;
-import software.amazon.awssdk.auth.signer.internal.Aws4SignerRequestParams;
 import software.amazon.awssdk.core.RequestClientOptions;
 import software.amazon.awssdk.core.exception.SdkClientException;
-import software.amazon.awssdk.core.runtime.auth.Signer;
 import software.amazon.awssdk.core.runtime.io.SdkDigestInputStream;
+import software.amazon.awssdk.core.signer.Signer;
 import software.amazon.awssdk.http.SdkHttpFullRequest;
 import software.amazon.awssdk.utils.Base64Utils;
 import software.amazon.awssdk.utils.BinaryUtils;
@@ -239,7 +238,7 @@ protected String getCanonicalizedQueryString(Map<String, List<String>> parameter
     }
 
     @ReviewBeforeRelease("Do we still want to make read limit user-configurable as in V1?")
-    protected static int getReadLimit(Aws4SignerRequestParams signerRequestParams) {
+    protected static int getReadLimit() {
         return RequestClientOptions.DEFAULT_STREAM_BUFFER_SIZE;
 
     }