Corrects behaviour which was returning null when config and credentials files were not found for profiles. Now it returns an empty map, as it used to

Author: martinKindall

CHANGELOG.md

@@ -1,3 +1,10 @@
+# __2.20.52__ __2023-04-24__
+## __Profile Files, Core__
+- ### Bugfixes
+    - The fix avoids a NullPointerException when calling the profiles() method
+    on a ProfileFile object, whose config/credentials files were not found in ~/.aws.
+    An empty map is returned instead, as in previous versions.
+
 # __2.20.51__ __2023-04-21__
 ## __AWS SDK for Java v2__
   - ### Features

core/profiles/src/main/java/software/amazon/awssdk/profiles/ProfileFile.java

@@ -117,7 +117,7 @@ public Optional<Profile> profile(String profileName) {
      */
     public Map<String, Profile> profiles() {
         Map<String, Profile> profileMap = profilesAndSectionsMap.get(PROFILES_SECTION_TITLE);
-        return profileMap != null ? Collections.unmodifiableMap(profileMap) : profileMap;
+        return profileMap != null ? Collections.unmodifiableMap(profileMap) : Collections.emptyMap();
     }
 
     @Override

core/profiles/src/test/java/software/amazon/awssdk/profiles/ProfileFileTest.java

@@ -554,6 +554,15 @@ public void loadingDefaultProfileFileWorks() {
         ProfileFile.defaultProfileFile();
     }
 
+    @Test
+    public void returnsEmptyMap_when_AwsFilesDoNotExist() {
+        ProfileFile missingProfile = ProfileFile.aggregator()
+                                                .build();
+
+        assertThat(missingProfile.profiles()).isEmpty();
+        assertThat(missingProfile.profiles()).isInstanceOf(Map.class);
+    }
+
     private ProfileFile configFile(String configFile) {
         return ProfileFile.builder()
                           .content(new StringInputStream(configFile))