Make 0 the disable value for ping duration

Author: dagnir

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/Http2Configuration.java

@@ -122,7 +122,7 @@ public interface Builder extends CopyableBuilder<Builder, Http2Configuration> {
          * Sets the period that the Netty client will send {@code PING} frames to the remote endpoint to check the
          * health of the connection. The default value is {@link
          * software.amazon.awssdk.http.nio.netty.internal.NettyConfiguration#HTTP2_CONNECTION_PING_TIMEOUT_SECONDS}. To
-         * disable this feature, set a duration of {@link Integer#MAX_VALUE} milliseconds or greater.
+         * disable this feature, set a duration of 0.
          *
          * @param healthCheckPingPeriod The ping period.
          * @return This builder for method chaining.

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/ChannelPipelineInitializer.java

@@ -17,6 +17,7 @@
 
 import static software.amazon.awssdk.http.nio.netty.internal.ChannelAttributeKey.PROTOCOL_FUTURE;
 import static software.amazon.awssdk.http.nio.netty.internal.NettyConfiguration.HTTP2_CONNECTION_PING_TIMEOUT_SECONDS;
+import static software.amazon.awssdk.utils.NumericUtils.saturatedCast;
 import static software.amazon.awssdk.utils.StringUtils.lowerCase;
 
 import io.netty.channel.Channel;
@@ -147,8 +148,8 @@ private void configureHttp2(Channel ch, ChannelPipeline pipeline) {
         pipeline.addLast(new Http2SettingsFrameHandler(ch, clientMaxStreams, channelPoolRef));
         if (healthCheckPingPeriod == null) {
             pipeline.addLast(new Http2PingHandler(HTTP2_CONNECTION_PING_TIMEOUT_SECONDS * 1_000));
-        } else if (healthCheckPingPeriod.toMillis() <= Integer.MAX_VALUE) {
-            pipeline.addLast(new Http2PingHandler((int) healthCheckPingPeriod.toMillis()));
+        } else if (healthCheckPingPeriod.toMillis() > 0) {
+            pipeline.addLast(new Http2PingHandler(saturatedCast(healthCheckPingPeriod.toMillis())));
         }
     }
 

http-clients/netty-nio-client/src/test/java/software/amazon/awssdk/http/nio/netty/internal/http2/PingTimeoutTest.java

@@ -37,14 +37,12 @@
 import io.netty.handler.codec.http2.Http2FrameLogger;
 import io.netty.handler.codec.http2.Http2Headers;
 import io.netty.handler.codec.http2.Http2MultiplexHandler;
-import io.netty.handler.codec.http2.Http2PingFrame;
 import io.netty.handler.codec.http2.Http2Settings;
 import io.netty.handler.logging.LogLevel;
 import io.netty.handler.logging.LoggingHandler;
 import io.netty.handler.ssl.SslContext;
 import io.netty.handler.ssl.util.SelfSignedCertificate;
 import java.nio.ByteBuffer;
-import java.nio.charset.StandardCharsets;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.concurrent.CompletableFuture;
@@ -109,9 +107,9 @@ public void pingHealthCheck_10sec() {
     }
 
     @Test
-    public void pingHealthCheck_IntMax_disabled() throws Exception {
+    public void pingHealthCheck_0_disabled() throws Exception {
         expected.expect(TimeoutException.class);
-        CompletableFuture<Void> requestFuture = makeRequest(Duration.ofMillis(Integer.MAX_VALUE));
+        CompletableFuture<Void> requestFuture = makeRequest(Duration.ofMillis(0));
         try {
             requestFuture.get(8, TimeUnit.SECONDS);
         } finally {