Skip to content

Commit e715bb6

Browse files
authored
Revert "Handle header lists in URLConnection client (#4897)" (#4960)
This reverts commit b51a51c. This change may be causing issues with propagation of trace IDs.
1 parent 4de1e05 commit e715bb6

File tree

2 files changed

+1
-81
lines changed

2 files changed

+1
-81
lines changed

http-clients/url-connection-client/src/main/java/software/amazon/awssdk/http/urlconnection/UrlConnectionHttpClient.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ public String clientName() {
152152
private HttpURLConnection createAndConfigureConnection(HttpExecuteRequest request) {
153153
SdkHttpRequest sdkHttpRequest = request.httpRequest();
154154
HttpURLConnection connection = connectionFactory.createConnection(sdkHttpRequest.getUri());
155-
setHeaders(connection, sdkHttpRequest);
155+
sdkHttpRequest.forEachHeader((key, values) -> values.forEach(value -> connection.setRequestProperty(key, value)));
156156

157157
// connection.setRequestProperty("Transfer-Encoding", "chunked") does not work, i.e., property does not get set
158158
if (sdkHttpRequest.matchingHeaders("Transfer-Encoding").contains("chunked")) {
@@ -180,13 +180,6 @@ private HttpURLConnection createAndConfigureConnection(HttpExecuteRequest reques
180180
return connection;
181181
}
182182

183-
private void setHeaders(HttpURLConnection connection, SdkHttpRequest request) {
184-
request.forEachHeader((name, values) -> {
185-
String commaSeparated = String.join(",", values);
186-
connection.addRequestProperty(name, commaSeparated);
187-
});
188-
}
189-
190183
private HttpURLConnection createDefaultConnection(URI uri, SSLSocketFactory socketFactory) {
191184

192185
Optional<Proxy> proxy = determineProxy(uri);

http-clients/url-connection-client/src/test/java/software/amazon/awssdk/http/urlconnection/HeadersListTest.java

Lines changed: 0 additions & 73 deletions
This file was deleted.

0 commit comments

Comments
 (0)