Add transferEncoding for Streaming RequestBody with UnsignedPayload as True (#5906)

Author: joviegas

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/specs/ProtocolSpec.java

@@ -158,7 +158,7 @@ default CodeBlock streamingMarshallerCode(IntermediateModel model, OperationMode
             builder.add(".requiresLength(true)");
         }
 
-        if (opModel.getAuthType() == AuthType.V4_UNSIGNED_BODY) {
+        if (opModel.getAuthType() == AuthType.V4_UNSIGNED_BODY || opModel.isUnsignedPayload()) {
             builder.add(".transferEncoding(true)");
         }
 

codegen/src/test/java/software/amazon/awssdk/codegen/poet/client/AsyncClientClassTest.java

@@ -23,6 +23,7 @@
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.customContentTypeModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.customPackageModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.endpointDiscoveryModels;
+import static software.amazon.awssdk.codegen.poet.ClientTestModels.opsWithSigv4a;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.queryServiceModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.restJsonServiceModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.rpcv2ServiceModels;
@@ -116,6 +117,12 @@ public void asyncClientBatchManager() {
         assertThat(aSyncClientBatchManager, generatesTo("test-batchmanager-async.java"));
     }
 
+    @Test
+    public void asyncClientWithStreamingUnsignedPayload() {
+        AsyncClientClass asyncClientClass = createAsyncClientClass(opsWithSigv4a(), false);
+        assertThat(asyncClientClass, generatesTo("test-unsigned-payload-trait-async-client-class.java"));
+    }
+
     private AsyncClientClass createAsyncClientClass(IntermediateModel model) {
         return new AsyncClientClass(GeneratorTaskParams.create(model, "sources/", "tests/", "resources/"));
     }

codegen/src/test/java/software/amazon/awssdk/codegen/poet/client/SyncClientClassTest.java

@@ -21,6 +21,7 @@
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.customContentTypeModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.customPackageModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.endpointDiscoveryModels;
+import static software.amazon.awssdk.codegen.poet.ClientTestModels.opsWithSigv4a;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.queryServiceModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.restJsonServiceModels;
 import static software.amazon.awssdk.codegen.poet.ClientTestModels.rpcv2ServiceModels;
@@ -104,4 +105,11 @@ private SyncClientClass createSyncClientClass(IntermediateModel model, boolean u
         model.getCustomizationConfig().setUseSraAuth(useSraAuth);
         return createSyncClientClass(model);
     }
+
+    @Test
+    public void syncClientClassWithUnsignedPayload() {
+        SyncClientClass syncClientClass = createSyncClientClass(opsWithSigv4a());
+        assertThat(syncClientClass, generatesTo("test-unsigned-payload-trait-sync-client-class.java"));
+    }
+
 }

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/client/c2j/ops-with-auth-sigv4a-value/service-2.json

@@ -215,6 +215,26 @@
             "auth": ["aws.auth#sigv4","aws.auth#sigv4a"],
             "unsignedPayload": true,
             "documentation": "<p>Performs a GET request to get-row with unsigned payload and auth as sigv4 and sigv4a.</p>"
+        },
+        "opWithSigv4UnSignedPayloadAndStreaming": {
+            "name": "opWithSigv4UnSignedPayload",
+            "http": {
+                "method": "GET",
+                "requestUri": "/get-row/"
+            },
+            "input": {
+                "shape": "GetRowRequestWithStreaming"
+            },
+            "output": {
+                "shape": "GetRowResponse"
+            },
+            "errors": [
+                {
+                    "shape": "InvalidInputException"
+                }
+            ],
+            "unsignedPayload": true,
+            "documentation": "<p>Performs a GET with unsignedPayload streaming.</p>"
         }
     },
     "shapes": {
@@ -287,6 +307,17 @@
             },
             "exception": true
         },
+        "GetRowRequestWithStreaming":{
+            "type":"structure",
+            "members":{
+                "Body":{
+                    "shape":"Body",
+                    "streaming":true
+                }
+            },
+            "payload":"Body"
+        },
+        "Body":{"type":"blob"},
         "String":{"type":"string"},
         "invalidInputMessage":{"type":"string"}
     },