Skip to content

Commit fc476a6

Browse files
committed
rebased and added CRT in Integ test
1 parent c99a8f4 commit fc476a6

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import org.junit.jupiter.api.BeforeEach;
2323
import software.amazon.awssdk.services.s3.S3AsyncClient;
2424

25-
public class S3CrtCrossRegionIntegrationTest extends S3AsyncCrossRegionIntegrationTestBase {
26-
private static final String BUCKET = temporaryBucketName(S3CrtCrossRegionIntegrationTest.class);
25+
public class S3CrossRegionAsyncIntegrationTest extends S3CrossRegionAsyncIntegrationTestBase {
26+
private static final String BUCKET = temporaryBucketName(S3CrossRegionAsyncIntegrationTest.class);
2727

2828
@BeforeAll
2929
static void setUpClass() {
@@ -38,12 +38,12 @@ static void clearClass() {
3838

3939
@BeforeEach
4040
public void initialize() {
41-
// TODO : Update this with crtBuilder ones CRT related PR is merged
4241
crossRegionS3Client = S3AsyncClient.builder()
4342
.region(CROSS_REGION)
4443
.serviceConfiguration(s -> s.crossRegionAccessEnabled(true))
4544
.build();
4645
}
46+
4747
@Override
4848
protected String bucketName() {
4949
return BUCKET;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import software.amazon.awssdk.services.s3.model.S3Object;
3737
import software.amazon.awssdk.services.s3.paginators.ListObjectsV2Publisher;
3838

39-
public abstract class S3AsyncCrossRegionIntegrationTestBase extends S3CrossRegionIntegrationTestBase{
39+
public abstract class S3CrossRegionAsyncIntegrationTestBase extends S3CrossRegionIntegrationTestBase{
4040
protected S3AsyncClient crossRegionS3Client;
4141

4242
@Override
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import org.junit.jupiter.api.BeforeEach;
2323
import software.amazon.awssdk.services.s3.S3AsyncClient;
2424

25-
public class S3AsyncCrossRegionIntegrationTest extends S3AsyncCrossRegionIntegrationTestBase {
26-
private static final String BUCKET = temporaryBucketName(S3AsyncCrossRegionIntegrationTest.class);
25+
public class S3CrossRegionCrtIntegrationTest extends S3CrossRegionAsyncIntegrationTestBase {
26+
private static final String BUCKET = temporaryBucketName(S3CrossRegionCrtIntegrationTest.class);
2727

2828
@BeforeAll
2929
static void setUpClass() {
@@ -38,12 +38,11 @@ static void clearClass() {
3838

3939
@BeforeEach
4040
public void initialize() {
41-
crossRegionS3Client = S3AsyncClient.builder()
41+
crossRegionS3Client = S3AsyncClient.crtBuilder()
4242
.region(CROSS_REGION)
43-
.serviceConfiguration(s -> s.crossRegionAccessEnabled(true))
43+
.crossRegionAccessEnabled(true)
4444
.build();
4545
}
46-
4746
@Override
4847
protected String bucketName() {
4948
return BUCKET;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
import software.amazon.awssdk.services.s3.model.PutObjectResponse;
4242
import software.amazon.awssdk.services.s3.model.S3Object;
4343

44-
public class S3SyncCrossRegionIntegrationTest extends S3CrossRegionIntegrationTestBase {
45-
private static final String BUCKET = temporaryBucketName(S3SyncCrossRegionIntegrationTest.class);
44+
public class S3CrossRegionSyncIntegrationTest extends S3CrossRegionIntegrationTestBase {
45+
private static final String BUCKET = temporaryBucketName(S3CrossRegionSyncIntegrationTest.class);
4646
private S3Client crossRegionS3Client;
4747

4848
@BeforeAll

0 commit comments

Comments
 (0)