Skip to content

Allow connectionTimeToLive to set to zero in netty http client. #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Aug 7, 2020

Description

Allow connectionTimeToLive to set to zero in netty http client.

Motivation and Context

#1976

Testing

n/a

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-commenter
Copy link

Codecov Report

Merging #1978 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1978      +/-   ##
============================================
- Coverage     76.68%   76.64%   -0.04%     
  Complexity      225      225              
============================================
  Files          1112     1112              
  Lines         33653    33584      -69     
  Branches       2621     2598      -23     
============================================
- Hits          25808    25742      -66     
+ Misses         6569     6565       -4     
- Partials       1276     1277       +1     
Flag Coverage Δ Complexity Δ
#unittests 76.64% <100.00%> (-0.04%) 225.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...awssdk/http/nio/netty/NettyNioAsyncHttpClient.java 70.12% <100.00%> (ø) 0.00 <0.00> (ø)
.../awssdk/http/apache/internal/net/SdkSslSocket.java 36.36% <0.00%> (-22.73%) 0.00% <0.00%> (ø%)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 60.76% <0.00%> (-3.85%) 0.00% <0.00%> (ø%)
...ty/internal/IdleConnectionCountingChannelPool.java 85.36% <0.00%> (-3.66%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...tials/WebIdentityTokenFileCredentialsProvider.java 35.55% <0.00%> (-2.23%) 0.00% <0.00%> (ø%)
...ery/internal/marshall/QueryMarshallerRegistry.java 77.77% <0.00%> (-2.23%) 0.00% <0.00%> (ø%)
...awssdk/codegen/poet/client/specs/ProtocolSpec.java 83.33% <0.00%> (-1.78%) 0.00% <0.00%> (ø%)
.../amazon/awssdk/http/apache/ProxyConfiguration.java 49.03% <0.00%> (-0.97%) 0.00% <0.00%> (ø%)
...internal/client/DefaultDynamoDbEnhancedClient.java 63.46% <0.00%> (-0.69%) 0.00% <0.00%> (ø%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e0e8b...692bc3c. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@zoewangg zoewangg merged commit 2c1cfab into master Aug 7, 2020
@zoewangg zoewangg deleted the zoewang/relaxConnectionTimeToLiveValidation branch August 7, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants