Skip to content

Remove eventLoopGroup and hostResolver configs #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 2, 2020

Description

  • Bump up CRT version
  • Remove eventLoopGroup and hostResolver configs. A static event loop group and host resolver will be used.

Motivation and Context

We will add customized elg config back once we figure out if we can/want to create an SdkEventLoopGroup w/o exposing the underlying EventLoopGroup

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang/crtUpdates-removeElg branch 2 times, most recently from 3a09973 to 0eeeab0 Compare September 2, 2020 23:23
@zoewangg zoewangg force-pushed the zoewang/crtUpdates-removeElg branch from 0eeeab0 to 7a94bc5 Compare September 3, 2020 00:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@zoewangg zoewangg merged commit 8bed1b8 into aws-crt-dev-preview Sep 3, 2020
@zoewangg zoewangg deleted the zoewang/crtUpdates-removeElg branch September 3, 2020 00:54
aws-sdk-java-automation added a commit that referenced this pull request May 13, 2022
…5f97e3790

Pull request: release <- staging/b9d5157e-5bba-4676-88d9-4805f97e3790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants