Adding validation to Region class #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
approved these changes
Oct 25, 2017
Closed
kiiadi
approved these changes
Oct 25, 2017
| * @return The region associated with the provided name. | ||
| */ | ||
| public static Region of(String value) { | ||
| Validate.notBlank(value, "Region value can't be null, empty or blank."); |
There was a problem hiding this comment.
Would this be better as Validate.paramNotBlank(value, "region");
There was a problem hiding this comment.
Oh - it doesn't exist - maybe it should
There was a problem hiding this comment.
What would paramNotBlank do that notBlank wouldn't?
| @Test(expected = IllegalArgumentException.class) | ||
| public void of_ThrowsIllegalArgumentException_WhenBlankString() { | ||
| Region.of(" "); | ||
| } |
spfink
force-pushed
the
finks/region-validation
branch
from
5f2c500 to
c1338bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least adds some validation for #217
Description
Adds validation to Region.of(String value) to throw on null, empty or blank strings.
Motivation and Context
#217
Testing
Added additional test class.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense