[Hackathon] Adds wrappers providing shortcuts to S3 getUrl and S3Presigner #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bennett-Lynch
approved these changes
Mar 2, 2022
| * @return The presigner | ||
| */ | ||
| @SdkExtensionMethod | ||
| default S3Presigner presigner() { |
There was a problem hiding this comment.
We could also expose individual methods here, like presignGetObject, presignPutObject, etc. But it would be a lot of duplication of interfaces. At the same time, it's more in-line with the methods being discovered as a first-class citizen on the native API. WDYT?
There was a problem hiding this comment.
I debated back and forth on this question and decided to not do it for the hackathon, since it is a lot of boilerplate. For "real" it's up for discussion but should be easy enough to add.
|
SonarCloud Quality Gate failed. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 17, 2024
…47c80612f Pull request: release <- staging/d60723c4-7f8c-4fa2-ae1f-57f47c80612f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.