Remove unnecessary dependencies on JDK modules not in java.base. #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/remove-transients
branch
2 times, most recently
from
6a0e8f5 to
482544b
Compare
This didn't remove all of the dependencies on such modules, just the unnecessary ones. Also added a checkstyle rule to prevent such dependencies in the future (except where they are intentional).
millems
force-pushed
the
millem/remove-transients
branch
from
482544b to
fd3017e
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't remove all of the dependencies on such modules, just the unnecessary ones.
Also added a checkstyle rule to prevent such dependencies in the future (except where they are intentional).
Fixes #3041 .