Codegen decorator class #3199
Merged
Codegen decorator class #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/codegenDecorator
branch
from
abcbf72 to
249134c
Compare
zoewangg
commented
May 18, 2022
| @@ -25,11 +25,18 @@ | |||
| /** | |||
| * Extension and convenience methods to Poet that use the intermediate model. | |||
| */ | |||
| public class PoetExtensions { | |||
| public class PoetExtension { | |||
There was a problem hiding this comment.
Checkstyle suddenly failed due to plural name (guess it's because I made changes to this class)
millems
reviewed
May 19, 2022
codegen/src/main/java/software/amazon/awssdk/codegen/poet/PoetExtension.java
Outdated
Show resolved
Hide resolved
.../main/java/software/amazon/awssdk/codegen/poet/client/AbstractAsyncClientDecoratorClass.java
Outdated
Show resolved
Hide resolved
.../main/java/software/amazon/awssdk/codegen/poet/client/AbstractAsyncClientDecoratorClass.java
Outdated
Show resolved
Hide resolved
...t/resources/software/amazon/awssdk/codegen/poet/client/test-abstract-async-client-class.java
Outdated
Show resolved
Hide resolved
...t/resources/software/amazon/awssdk/codegen/poet/client/test-abstract-async-client-class.java
Outdated
Show resolved
Hide resolved
millems
approved these changes
May 19, 2022
|
Kudos, SonarCloud Quality Gate passed! |
zoewangg
added a commit
that referenced
this pull request
May 24, 2022
* Codegen decorator * Fix checkstyle * Rename class and move constants
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add customization and codegen abstract service client
This PR builds on top of #3195.