Skip to content

Fixed bug in VersionedRecord that did not allow special characters in… #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

cenedhryn
Copy link
Contributor

… version key name, github issues #2507, #2950, #3279

Motivation and Context

The VersionedRecordExtension makes use of the VersionedRecord tag/annotation, letting users auto-increment versions of their records. However the extension does not use ExpressionNames in its conditions/expressions, only ExpressionValues. Therefore, if your record has a version attribute with reserved words or special characters, DDB put/update item calls will fail.

Modifications

  • Modified VersionedRecordExtension to use expression names for new and updated versions
  • Concentrated the keyref/valueref functions to a single place in the library for easier reference and less code duplication

Testing

All tests pass

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@cenedhryn cenedhryn requested a review from a team as a code owner July 7, 2022 21:05
@cenedhryn cenedhryn force-pushed the salande/V611421107-ddbe branch from fd511c5 to 4e9aa53 Compare July 7, 2022 21:08
@cenedhryn cenedhryn requested a review from joviegas July 8, 2022 23:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cenedhryn cenedhryn merged commit 5b67967 into master Jul 15, 2022
@cenedhryn cenedhryn deleted the salande/V611421107-ddbe branch July 15, 2022 16:12
aws-sdk-java-automation added a commit that referenced this pull request Sep 25, 2024
…5f6cbf5ef

Pull request: release <- staging/c5e0a6eb-3c46-4806-a826-a5a5f6cbf5ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants