Skip to content

Use the endpoint operation for client endpoin tests if exists #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Feb 13, 2023

Motivation and Context

If the service uses endpoint discovery, default to the service's endpoint operation, otherwise we risk picking an operation that relies on endpoint discovery, in which case the client endpoint tests will be useless because we skip using the Endpoints 2.0 endpoint provider if we have an endpoint from Endpoint Discovery.

Modifications

Use the endpoint operation by default for client endpoint tests if the service has one.

Testing

mvn clean install

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

If the service uses endpoint discovery, default to the service's endpoint
operation, otherwise we risk picking an operation that relies on endpoint
discovery, in which case the client endpoint tests will be useless because we
skip using the Endpoints 2.0 endpoint provider if we have an endpoint from
Endpoint Discovery.
@dagnir dagnir force-pushed the dongie/client-endpoint-test-default-op branch from 3a31f85 to 0450024 Compare February 13, 2023 21:06
@dagnir dagnir marked this pull request as ready for review February 13, 2023 21:50
@dagnir dagnir requested a review from a team as a code owner February 13, 2023 21:51
@dagnir dagnir enabled auto-merge (squash) February 13, 2023 22:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit a6bf106 into master Feb 13, 2023
aws-sdk-java-automation added a commit that referenced this pull request Mar 20, 2025
…f6d1e2eb8

Pull request: release <- staging/2c3a913b-35e5-4e9d-b6e5-a45f6d1e2eb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants